1196591 - Member in MediaBufferResource potentially not initialized before use

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

In bug 1190238, the initialization of member BufferMediaResource::mOffset was removed.

This is incorrect.

A fly-by rebase made me notice the problem

Comment 1

[Jean-Yves Avenard [:jya]]

Note that it doesn't matter as a call to BufferMediaResource::ReadAt is always done first which will set the mOffset value.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8e5f72da53a

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8e5f72da53a

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: 0001-Bug-1196591-Initialize-member.-r-me.patch

Approval Request Comment
[Feature/regressing bug #]:1190238
[User impact if declined]: don't believe there's any
[Describe test coverage new/current, TreeHerder]: in central
[Risks and why]: non-existent
[String/UUID change made/needed]:none

The incorrect change happened while performing a rebase.
I've fixed it immediately when i notice it (during the beta rebase) but it slipped through aurora.

This just remove the incorrect removal of the member initialization. it goes back to what was there before bug 1190238

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2452b513ecc2