Closed
Bug 1196638
Opened 10 years ago
Closed 10 years ago
EventUtils infers the wrong button when synthesizing contextMenu clicks
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
4.63 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
This ends up causing nsPresShell to determine that it's a key-equiv, and makes the context menu appear at the top-left of the content area, instead of the area where it was targeted.
It looks like Martijn ran into the same problem in bug 916086 and fixed one of the callsites, but not all of them. :-(
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8650300 -
Flags: review?(jmaher)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8650300 [details] [diff] [review]
Infer the proper button for synthesized mouse clicks on all callsites. v1
Review of attachment 8650300 [details] [diff] [review]:
-----------------------------------------------------------------
good find.
Attachment #8650300 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #3)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=61c751e43925
Needed some fixups.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=749f4542c697
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•