1196836 - Remove _get_partial_info() from desktop_l10n.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

No more partials!

Comment 1

[Rail Aliiev [:rail]]

Attachment: no_more_partials-mozharness.diff

Comment 2

[Jordan Lund (:jlund)]

Comment on attachment 8656610 [details] [diff] [review]
no_more_partials-mozharness.diff

Review of attachment 8656610 [details] [diff] [review]:
-----------------------------------------------------------------

exciting! I'm guessing the release bits (single_locale, bouncer) will need to keep partial code while this rides trains?

Comment 3

[Rail Aliiev [:rail]]

We still need partials for Bouncer - that is used by release builds. But partial_mar can be deleted from single_locale configs for sure.

Comment 4

[Jordan Lund (:jlund)]

okay, tracking here the two further places we could bring out the axe for

1)

<jlund> rail: so I wonder if we can delete https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#1492 and https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#98 if desktop and desktop_l10n are not doing partials anymore then.
<rail> jlund: I think so... I'd ask mshal first, the "TC" suffix makes me not 100% sure

2)

partial_mar can be deleted from single_locale configs

Comment 5

[Michael Shal [:mshal]]

(In reply to Jordan Lund (:jlund) from comment #4)
> okay, tracking here the two further places we could bring out the axe for
> 
> 1)
> 
> <jlund> rail: so I wonder if we can delete
> https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/
> mozilla/building/buildbase.py#1492 and
> https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/
> mozilla/building/buildbase.py#98 if desktop and desktop_l10n are not doing
> partials anymore then.
> <rail> jlund: I think so... I'd ask mshal first, the "TC" suffix makes me
> not 100% sure

That should be fine to go - the TC suffix ones aren't actually used anywhere. We just added that because we still wanted to submit completes/partials with FTP URLs instead of TC URLs.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71a0983417c2

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8656610 [details] [diff] [review]
no_more_partials-mozharness.diff

https://hg.mozilla.org/build/mozharness/rev/bcbca32eab32
https://hg.mozilla.org/integration/mozilla-inbound/rev/71a0983417c2

Comment 8

[Release Engineering SlaveAPI Service]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/71a0983417c2