Add EnforceRange to getAll/getAllKeys to match the spec, and expose them unconditionally

RESOLVED FIXED in Firefox 44

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla44
dev-doc-complete, site-compat
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

Created attachment 8650583 [details] [diff] [review]
0002-idb-enforcerange.patch
Attachment #8650583 - Flags: review?(amarchesini)
Summary: Add EnforceRange to getAll/getAllKeys to match the spec → Add EnforceRange to getAll/getAllKeys to match the spec, and expose them unconditionally
Comment on attachment 8650583 [details] [diff] [review]
0002-idb-enforcerange.patch

Review of attachment 8650583 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/IDBIndex.webidl
@@ +40,5 @@
>  };
>  
>  partial interface IDBIndex {
>      [Throws]
> +    IDBRequest mozGetAll (optional any key, [EnforceRange] optional unsigned long limit);

Do we have any follow up to deprecate these 2 methods?

::: dom/webidl/IDBObjectStore.webidl
@@ -71,3 @@
>  
> -    [Throws,
> -     Func="mozilla::dom::indexedDB::IndexedDatabaseManager::ExperimentalFeaturesEnabled"]

Seems that we use ::ExperimentalFeaturesEnabled only in IDBDatabase.webidl for |StorageType storage|. Can you can if we can get rid of that one too?
Attachment #8650583 - Flags: review?(amarchesini) → review+
Keywords: dev-doc-needed
What's our plan for shipping this?
Flags: needinfo?(khuey)
I heard from khuey elsewhere that the plan was to await browser interop and it looks like that's coming soon.
Flags: needinfo?(khuey)
https://hg.mozilla.org/mozilla-central/rev/64dbcad7bc6c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.