1196841 - Add EnforceRange to getAll/getAllKeys to match the spec, and expose them unconditionally

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: 0002-idb-enforcerange.patch

Comment 1

[Andrea Marchesini [:baku]]

Comment on attachment 8650583 [details] [diff] [review]
0002-idb-enforcerange.patch

Review of attachment 8650583 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/IDBIndex.webidl
@@ +40,5 @@
>  };
>  
>  partial interface IDBIndex {
>      [Throws]
> +    IDBRequest mozGetAll (optional any key, [EnforceRange] optional unsigned long limit);

Do we have any follow up to deprecate these 2 methods?

::: dom/webidl/IDBObjectStore.webidl
@@ -71,3 @@
>  
> -    [Throws,
> -     Func="mozilla::dom::indexedDB::IndexedDatabaseManager::ExperimentalFeaturesEnabled"]

Seems that we use ::ExperimentalFeaturesEnabled only in IDBDatabase.webidl for |StorageType storage|. Can you can if we can get rid of that one too?

Comment 2

[Andrew Overholt [:overholt]]

What's our plan for shipping this?

Comment 3

[Andrew Overholt [:overholt]]

I heard from khuey elsewhere that the plan was to await browser interop and it looks like that's coming soon.

Comment 4

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/idbobjectstore-getall-and-related-methods-will-be-unprefixed/

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64dbcad7bc6c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64dbcad7bc6c

Comment 7

[Jean-Yves Perrier [:teoli]]

Updated docs:
https://developer.mozilla.org/en-US/Firefox/Releases/44#IndexedDB
https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/getAll
https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/getAllKeys
https://developer.mozilla.org/en-US/docs/Web/API/IDBObjectStore/getAllKeys
https://developer.mozilla.org/en-US/docs/Web/API/IDBObjectStore/getAll

Comment 8

[juraj.masiar]

The Browser compatibility section in MDN still says: " From version 44: this feature is behind the dom.indexedDB.experimental preference. To change preferences in Firefox, visit about:config."

It's no longer true, right?
See the docs here:
https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/getAllKeys
https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/getAll
https://developer.mozilla.org/en-US/docs/Web/API/IDBObjectStore/getAll

Comment 9

[wOxxOm]

MDN still says: " From version 44: this feature is behind the dom.indexedDB.experimental preference. [...]"

That's a mistake which occurred when :teoli changed only the previous version number but forgot to remove the no longer relevant comment (because getAll was present since FF25 or earlier hidden behind the flag). Here's a pending PR that with a fix: https://github.com/mdn/browser-compat-data/pull/5475