Closed Bug 1196841 Opened 5 years ago Closed 5 years ago

Add EnforceRange to getAll/getAllKeys to match the spec, and expose them unconditionally

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: khuey, Assigned: khuey)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

No description provided.
Attachment #8650583 - Flags: review?(amarchesini)
Summary: Add EnforceRange to getAll/getAllKeys to match the spec → Add EnforceRange to getAll/getAllKeys to match the spec, and expose them unconditionally
Comment on attachment 8650583 [details] [diff] [review]
0002-idb-enforcerange.patch

Review of attachment 8650583 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/IDBIndex.webidl
@@ +40,5 @@
>  };
>  
>  partial interface IDBIndex {
>      [Throws]
> +    IDBRequest mozGetAll (optional any key, [EnforceRange] optional unsigned long limit);

Do we have any follow up to deprecate these 2 methods?

::: dom/webidl/IDBObjectStore.webidl
@@ -71,3 @@
>  
> -    [Throws,
> -     Func="mozilla::dom::indexedDB::IndexedDatabaseManager::ExperimentalFeaturesEnabled"]

Seems that we use ::ExperimentalFeaturesEnabled only in IDBDatabase.webidl for |StorageType storage|. Can you can if we can get rid of that one too?
Attachment #8650583 - Flags: review?(amarchesini) → review+
What's our plan for shipping this?
Flags: needinfo?(khuey)
I heard from khuey elsewhere that the plan was to await browser interop and it looks like that's coming soon.
Flags: needinfo?(khuey)
https://hg.mozilla.org/mozilla-central/rev/64dbcad7bc6c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
The Browser compatibility section in MDN still says: " From version 44: this feature is behind the dom.indexedDB.experimental preference. To change preferences in Firefox, visit about:config."

It's no longer true, right?
See the docs here:
https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/getAllKeys
https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/getAll
https://developer.mozilla.org/en-US/docs/Web/API/IDBObjectStore/getAll

MDN still says: " From version 44: this feature is behind the dom.indexedDB.experimental preference. [...]"

That's a mistake which occurred when :teoli changed only the previous version number but forgot to remove the no longer relevant comment (because getAll was present since FF25 or earlier hidden behind the flag). Here's a pending PR that with a fix: https://github.com/mdn/browser-compat-data/pull/5475

You need to log in before you can comment on or make changes to this bug.