Closed
Bug 1196878
Opened 9 years ago
Closed 9 years ago
Security error unreadable with dark theme
Categories
(DevTools :: Netmonitor, defect)
DevTools
Netmonitor
Tracking
(firefox43 fixed)
VERIFIED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: jryans, Assigned: grapherd, Mentored)
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(2 files, 1 obsolete file)
150.03 KB,
image/png
|
Details | |
840 bytes,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
The error text in the security panel is basically unreadable in the dark theme. See attached screenshot.
Reporter | ||
Updated•9 years ago
|
Mentor: jryans
Whiteboard: [good first bug][lang=css]
Comment 1•9 years ago
|
||
Hi Ryan, I want to work on this bug. Could you tell me where to make the change? I am checking the code and didn't found a css rule where to add the change for the color, so I think it's necessary create a new one. Added to it, could you tell me what is the color (variable with the color) you want for the text? Thanks
Flags: needinfo?(jryans)
fixed Bug 1196878, add .theme-dark #security-error-message for font color.
Attachment #8651511 -
Flags: review?(jryans)
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Giovanny Gongora [:gioyik] from comment #1) > Hi Ryan, > > I want to work on this bug. Could you tell me where to make the change? I am > checking the code and didn't found a css rule where to add the change for > the color, so I think it's necessary create a new one. Added to it, could > you tell me what is the color (variable with the color) you want for the > text? It looks like grapherd jumped ahead with a patch for this one, so it's probably best to look for another bug to try. In general though, you can use the Browser Toolbox[1] to inspect the tools and tweak style like regular web content. The various DevTools theme variables are listed on MDN[2]. As for which one... I wouldn't really know myself until I've looked at other similar text types. I'll be doing that momentarily as part of review. [1]: https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox [2]: https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors
Flags: needinfo?(jryans)
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → grapherd
Status: NEW → ASSIGNED
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8651511 [details] [diff] [review] Bug 1196878.patch This change looks good to me! However, can you correct the commit message to say "r=jryans" at the end? Also, I'll run a try build to ensure it's safe to land: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e8354fa7104
Attachment #8651511 -
Flags: review?(jryans) → feedback+
fixed reviewer in patch commit
Attachment #8652870 -
Flags: review?(jryans)
Reporter | ||
Updated•9 years ago
|
Attachment #8651511 -
Attachment is obsolete: true
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8652870 [details] [diff] [review] 1196878.patch Review of attachment 8652870 [details] [diff] [review]: ----------------------------------------------------------------- Great, this looks good to me. The try run looks good too, so let's mark it for landing. Thank you for working on this!
Attachment #8652870 -
Flags: review?(jryans) → review+
Reporter | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dc2cd8274358
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment 9•9 years ago
|
||
I have reproduced this bug on Nightly 43.0a1 (2015-08-20) on ubuntu 14.04 LTS, 32 bit! The bug's fix is now verified on Latest Beta 43.0b1! Build ID: 20151103023037 User Agent: Mozilla/5.0 (X11; Linux i686; rv:43.0) Gecko/20100101 Firefox/43.0 [bugday-20151104]
Comment 10•8 years ago
|
||
I have reproduced this bug on Nightly 43.0a1 (2015-08-20) on windows 8.1 , 64 bit! The bug's fix is now verified on Latest Beta 48.0b9! Build ID: 20160718142219 User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 [bugday-20160727]
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•