1196941 - Data too long for column 'lang' at row 1

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect, P2)

Description

[Andy McKay]

http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/19664/

looks like: lang=sr-Latn

Comment 1

[David Durst [:ddurst]]

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 87, in get_response
    response = middleware_method(request)
  File "mkt/site/middleware.py", line 128, in process_request
    request.user.save()
  File "mkt/site/models.py", line 223, in save
    result = super(OnChangeMixin, self).save(*args, **kw)
  File "django/db/models/base.py", line 589, in save
    force_update=force_update, update_fields=update_fields)
  File "django/db/models/base.py", line 617, in save_base
    updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
  File "django/db/models/base.py", line 679, in _save_table
    forced_update)
  File "django/db/models/base.py", line 723, in _do_update
    return filtered._update(values) > 0
  File "django/db/models/query.py", line 600, in _update
    return query.get_compiler(self.db).execute_sql(CURSOR)
  File "django/db/models/sql/compiler.py", line 1005, in execute_sql
    cursor = super(SQLUpdateCompiler, self).execute_sql(result_type)
  File "django/db/models/sql/compiler.py", line 787, in execute_sql
    cursor.execute(sql, params)
  File "django/db/backends/utils.py", line 65, in execute
    return self.cursor.execute(sql, params)
  File "django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "django/db/backends/utils.py", line 65, in execute
    return self.cursor.execute(sql, params)
  File "django/db/backends/mysql/base.py", line 129, in execute
    return self.cursor.execute(query, args)
  File "MySQLdb/cursors.py", line 205, in execute
    self.errorhandler(self, exc, value)
  File "MySQLdb/connections.py", line 36, in defaulterrorhandler
    raise errorclass, errorvalue



Headers:

Accept
text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8

Accept-Encoding 
gzip, deflate

Accept-Language 
sr-Latn,sr;q=0.8,sr-rs;q=0.7,sr-cs;q=0.5,en-us;q=0.3,en;q=0.2

Cache-Control 
no-cache

Connection 
keep-alive

Content-Length 
23

Content-Type 
application/x-www-form-urlencoded; charset=UTF-8

Dnt 
1

Host 
marketplace.firefox.com

Pragma 
no-cache

Referer 
https://marketplace.firefox.com/app/play-drum?src=entertainment-popular

User-Agent 
Mozilla/5.0 (Mobile; ALCATELOneTouch4012X; rv:18.1) Gecko/18.1 Firefox/18.1

X-Forwarded-For 
79.110.157.171

Comment 2

[David Durst [:ddurst]]

If we're supposed to be supporting Serbian, then perhaps we're not properly parsing the Accept-Language header? [grasps at straws]

Comment 3

[Mathieu Pillard [:mat]]

We're storing the lang on the user but the lang column was never meant to support locales of more than 5 chars. A simple migration to change the max length of the column should fix it, I'll get right on it.

Comment 4

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/commit/87d2a987f2009d6bba02e5633e117641964fb2a3

STR:
- Log in in Marketplace devhub
- Set your browser to prefer content in sr-Latn locale, or just browse to /developers/?lang=sr-Latn while logged in
- Make sure the page is displayed correctly in Serbian without errors.
- Go to the consumer pages, visit a detail page for any app, make sure it's also displayed in Serbian.

Comment 5

[Victor Carciu]

Verified as fixed