1196969 - Custom fields whose visibility depends on the product are not displayed/hidden correctly

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

For some reason, the product field is not displayed using bug/field.html.tmpl and so doesn't contain the JS code which controls the visibility of custom fields depending on it. This explains why a custom field remains visible/hidden when it shouldn't. This is very problematic, because if a mandatory custom field is supposed to be displayed but is not, process_bug.cgi will reject your changes because the mandatory custom field contains no data. And so you have no way to submit your changes.

If the mandatory custom field is of type 'textarea', the (edit) link is displayed by default, but if this field is empty, the web browser will complain that you must enter some text, but is unable to point to the field because it's hidden. So I also fixed this problem.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1.1

My previous patch forgot to take classifications into account, if they are enabled.

Comment 2

[Gervase Markham [:gerv]]

Can you tell me what conditions reproduce this bug?

I have created a custom field which is mandatory and depends on the value of Product, but when I try and file a new bug in that product, the field is displayed correctly. And it's also displayed correctly when I update bugs in that product.

Gerv

Comment 3

[Frédéric Buclin]

If your mandatory custom field (e.g. a textarea field, so that you can test all pieces of the patch) is only displayed for productA and your are currently in productB, and you decide to move the bug into productA, Bugzilla will refuse to commit your changes, because you are supposed to enter some data into the mandatory custom field. But because this field is not displayed, you cannot enter any data in it and so you cannot move the bug into productA.

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 8650982 [details] [diff] [review]
patch, v1.1

Review of attachment 8650982 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv.

Gerv

Comment 5

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   7a99779..246c04a  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   2113247..7d3c1b0  5.0 -> 5.0