1197013 - Consider no longer animating alpha on menu/tabs tray buttons when opening tabs tray on phone

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Now that we removed the chrome at the bottom of the screen in the Tabs Tray (bug 1161638), we don't really need to hide the tabs tray icon or menu button, which can probably be a perf win.

However, it might break the illusion that the tabs tray is visible below the tab.

Anthony, do you have any thoughts? Let me know if I should throw up a build.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I still like the fade in. Unless its a huge perf win I think we should keep it for now.

But, I'm always open to seeing a build too :)

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

FTR, alpha change occurs here:
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbarPhoneBase.java?rev=d548ba019a7c#127

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Build: https://people.mozilla.com/~mcomella/apks/mcomella-1197013_01.apk

IMO, no perf gains.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thank you for the build mcomella!

I tested it out on my N6 and I like the fade. Even when I'm not specifically looking for it, it works well.

I think I'll close this as a WONTFIX then.