1197043 - use flags to distinguish between AudioNodeStreams wanting external streams and main thread events

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Karl Tomlinson (:karlt)]

This is mostly preparation work for bug 1196108, but there are some small advantages with just these changes.

MediaStreamAudioDestinationNode does not need any main thread events because
mDOMStream provides GetCurrentTime to consumers.

MediaRecoder also does not use main thread current time.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1197043 remove unnecessary aSampleRate parameter for AudioNodeStream creation r?padenot

bug 1197043 remove unnecessary aSampleRate parameter for AudioNodeStream creation r?padenot

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1197043 rename Add/RemoveStream to Add/RemoveStreamGraphThread r?padenot

bug 1197043 rename Add/RemoveStream to Add/RemoveStreamGraphThread r?padenot

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1197043 introduce MediaStreamGraph::AddStream() r?padenot

bug 1197043 introduce MediaStreamGraph::AddStream() r?padenot

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1197043 move AudioNodeStream creation to stream class r?padenot

bug 1197043 move AudioNodeStream creation to stream class r?padenot

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1197043 use flags to distinguish between external streams and events r?padenot

bug 1197043 use flags to distinguish between external streams and events r?padenot

MediaStreamAudioDestinationNode does not need any main thread events because
mDOMStream provides GetCurrentTime to consumers.

MediaRecoder also does not use main thread current time.

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8650812 [details]
MozReview Request: bug 1197043 remove unnecessary aSampleRate parameter for AudioNodeStream creation r?padenot

https://reviewboard.mozilla.org/r/16701/#review15083

Ship It!

Comment 7

[Paul Adenot (:padenot)]

https://reviewboard.mozilla.org/r/16701/#review15087

Ship It!

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 8650814 [details]
MozReview Request: bug 1197043 introduce MediaStreamGraph::AddStream() r?padenot

https://reviewboard.mozilla.org/r/16705/#review15089

Ship It!

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8650813 [details]
MozReview Request: bug 1197043 rename Add/RemoveStream to Add/RemoveStreamGraphThread r?padenot

https://reviewboard.mozilla.org/r/16703/#review15085

Ship It!

Comment 10

[Paul Adenot (:padenot)]

Comment on attachment 8650815 [details]
MozReview Request: bug 1197043 move AudioNodeStream creation to stream class r?padenot

https://reviewboard.mozilla.org/r/16707/#review15091

Ship It!

Comment 11

[Paul Adenot (:padenot)]

Comment on attachment 8650816 [details]
MozReview Request: bug 1197043 use flags to distinguish between external streams and events r?padenot

https://reviewboard.mozilla.org/r/16709/#review15081

Ship It!

::: dom/media/webaudio/AudioNodeStream.h:54
(Diff revision 1)
> -  // to an nsAudioStream for playback.
> +    // to an nsAudioStream for playback.

We need to update this comment. We don't use AudioStream to output audio anymore since last year's refactoring (we're callback driven, now).

Comment 12

[Karl Tomlinson (:karlt)]

(In reply to Paul Adenot (:padenot) from comment #11)
> > -  // to an nsAudioStream for playback.
> > +    // to an nsAudioStream for playback.
> 
> We need to update this comment. We don't use AudioStream to output audio
> anymore since last year's refactoring (we're callback driven, now).

updated as:
"to other ProcessedMediaStreams or hardware audio output."

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a41e0971de4d
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fb3162d1662
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf6521da6a03
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f427969796d
https://hg.mozilla.org/integration/mozilla-inbound/rev/76997b5a67b8

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a41e0971de4d
https://hg.mozilla.org/mozilla-central/rev/9fb3162d1662
https://hg.mozilla.org/mozilla-central/rev/bf6521da6a03
https://hg.mozilla.org/mozilla-central/rev/6f427969796d
https://hg.mozilla.org/mozilla-central/rev/76997b5a67b8