Closed
Bug 1197078
Opened 9 years ago
Closed 9 years ago
Marionette service is unable to parse the data: "[JavaScript Error: "Error parsing incoming packet: {'r (SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data"
Categories
(Testing :: Marionette Client and Harness, defect)
Testing
Marionette Client and Harness
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
Details
(Keywords: pi-marionette-client)
Attachments
(1 file)
2.11 KB,
patch
|
automatedtester
:
review+
ato
:
feedback+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1194968 +++ transport.send now expects to get a json string, but we didn't send result of emulator command as json string. And marionette service cannot parse the data. == 19:26:25 WARNING - 08-20 01:36:41.918 E/GeckoConsole( 44): [JavaScript Error: "Error parsing incoming packet: {'r (SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data - JSONPacket.prototype.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/packets.js:164:20 ==
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8650868 [details] [diff] [review] Patch, v1 Review of attachment 8650868 [details] [diff] [review]: ----------------------------------------------------------------- Changes of this patch: 1. Send the result of emulator command JSON format. 2. Since we expect the emulator-shell is a list, so I add the check back. Try result for your reference: https://treeherder.mozilla.org/#/jobs?repo=try&revision=308f76d15dea&exclusion_profile=false May I have your review? Thank you.
Attachment #8650868 -
Flags: review?(ato)
Updated•9 years ago
|
Assignee: nobody → echen
Keywords: ateam-marionette-client
Comment 3•9 years ago
|
||
Comment on attachment 8650868 [details] [diff] [review] Patch, v1 Review of attachment 8650868 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me, thank you for patching it! Since I’m not a peer I can’t review this, but redirecting to dburns.
Attachment #8650868 -
Flags: review?(dburns)
Attachment #8650868 -
Flags: review?(ato)
Attachment #8650868 -
Flags: feedback+
Assignee | ||
Updated•9 years ago
|
Blocks: emu-x86-kk-tests
Comment 4•9 years ago
|
||
Comment on attachment 8650868 [details] [diff] [review] Patch, v1 Review of attachment 8650868 [details] [diff] [review]: ----------------------------------------------------------------- looks good. In future please use MozReview for patches to Marionette
Attachment #8650868 -
Flags: review?(dburns) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to David Burns :automatedtester from comment #4) > Comment on attachment 8650868 [details] [diff] [review] > Patch, v1 > > Review of attachment 8650868 [details] [diff] [review]: > ----------------------------------------------------------------- > > looks good. In future please use MozReview for patches to Marionette Okay, I will, thanks for the review.
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7b1861c0a2d9
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment 8•9 years ago
|
||
edgar, as an aside note this code is bound to change quite a bit again as part of bug 1211489 and its dependants.
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Andreas Tolfsen (:ato) from comment #8) > edgar, as an aside note this code is bound to change quite a bit again as > part of bug 1211489 and its dependants. Thanks for sharing this information to us!!!
Updated•1 year ago
|
Product: Testing → Remote Protocol
Comment 10•1 year ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•