1197078 - Marionette service is unable to parse the data: "[JavaScript Error: "Error parsing incoming packet: {'r (SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data"

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

+++ This bug was initially created as a clone of Bug #1194968 +++

transport.send now expects to get a json string, but we didn't send result of emulator command as json string. And marionette service cannot parse the data. 

==
19:26:25  WARNING -  08-20 01:36:41.918 E/GeckoConsole(   44): [JavaScript Error: "Error parsing incoming packet: {'r (SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data - JSONPacket.prototype.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/packets.js:164:20
==

Comment 1

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

Comment on attachment 8650868 [details] [diff] [review]
Patch, v1

Review of attachment 8650868 [details] [diff] [review]:
-----------------------------------------------------------------

Changes of this patch:
1. Send the result of emulator command JSON format.
2. Since we expect the emulator-shell is a list, so I add the check back.

Try result for your reference: https://treeherder.mozilla.org/#/jobs?repo=try&revision=308f76d15dea&exclusion_profile=false

May I have your review? Thank you.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8650868 [details] [diff] [review]
Patch, v1

Review of attachment 8650868 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, thank you for patching it!  Since I’m not a peer I can’t review this, but redirecting to dburns.

Comment 4

[David Burns :automatedtester]

Comment on attachment 8650868 [details] [diff] [review]
Patch, v1

Review of attachment 8650868 [details] [diff] [review]:
-----------------------------------------------------------------

looks good. In future please use MozReview for patches to Marionette

Comment 5

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

(In reply to David Burns :automatedtester from comment #4)
> Comment on attachment 8650868 [details] [diff] [review]
> Patch, v1
> 
> Review of attachment 8650868 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> looks good. In future please use MozReview for patches to Marionette

Okay, I will, thanks for the review.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/7b1861c0a2d9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b1861c0a2d9

Comment 8

[Andreas Tolfsen ❲:ato❳]

edgar, as an aside note this code is bound to change quite a bit again as part of bug 1211489 and its dependants.

Comment 9

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

(In reply to Andreas Tolfsen (:ato) from comment #8)
> edgar, as an aside note this code is bound to change quite a bit again as
> part of bug 1211489 and its dependants.

Thanks for sharing this information to us!!!

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Moving bugs for Marionette client due to component changes.