1197285 - Re-evaluate if SavedFrame subsumes checks need to handle a missing subsumes callback

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Follow up to bug 1194424.

IIRC, the case of a missing subsumes callback predates when the shell had principals and a subsumes callback of its own. Maybe we can remove it now? Let's try and find out...

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Remove null checks for subsumes callback in SavedStacks

Once upon a time, JS shell builds did not have principals nor a subsumes
callback, and so the SavedStacks infrastructure had to null check the subsumes
callback all the time in order to run shell tests. Since then, the JS shell
picked up its own principals and its own subsumes callback, and so all of these
null checks are no longer needed as the subsumes callback is always set by the
shell or the embedder.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Oh hm, I'm crashing in heap snapshot xpcshell tests with this patch now, actually. I guess those checks are still needed!