Re-evaluate if SavedFrame subsumes checks need to handle a missing subsumes callback

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

Follow up to bug 1194424.

IIRC, the case of a missing subsumes callback predates when the shell had principals and a subsumes callback of its own. Maybe we can remove it now? Let's try and find out...
Created attachment 8653142 [details] [diff] [review]
Remove null checks for subsumes callback in SavedStacks

Once upon a time, JS shell builds did not have principals nor a subsumes
callback, and so the SavedStacks infrastructure had to null check the subsumes
callback all the time in order to run shell tests. Since then, the JS shell
picked up its own principals and its own subsumes callback, and so all of these
null checks are no longer needed as the subsumes callback is always set by the
shell or the embedder.
Attachment #8653142 - Flags: review?(sphink)
Oh hm, I'm crashing in heap snapshot xpcshell tests with this patch now, actually. I guess those checks are still needed!
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
Attachment #8653142 - Attachment is obsolete: true
Attachment #8653142 - Flags: review?(sphink)
You need to log in before you can comment on or make changes to this bug.