Closed Bug 1197293 Opened 5 years ago Closed 5 years ago
fix bustage in taskcluster from upload-properties
Bug 1118778 landed some changes that fail if 'make upload' doesn't run: https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/QbXW1DAmRYWB3beFk0ugow/0/public/logs/live_backing.log 17:20:22 INFO - /home/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python /home/worker/workspace/build/src/build/gen_mach_buildprops.py --complete-mar-file dist/update/firefox-43.0a1.en-US.linux-x86_64.complete.mar --upload-properties dist/upload-properties.json 17:20:22 INFO - Traceback (most recent call last): 17:20:22 INFO - File "/home/worker/workspace/build/src/build/gen_mach_buildprops.py", line 65, in <module> 17:20:22 INFO - with open(args.upload_properties) as f: 17:20:22 INFO - IOError: [Errno 2] No such file or directory: 'dist/upload-properties.json' We don't do uploads in taskcluster, so indeed 'make upload' does not run.
Mike has offered to take a look at this
Assignee: dustin → mshal
Although mach_build_properties.json is largely useless for TC builds, it's a little trickier to have mozharness ignore that since it doesn't know the value of MOZ_AUTOMATION_UPLOAD. Though I may kill gen_mach_buildprops.py soon and just have upload.py output all the properties directly, so mozharness may need to treat it as an optional file then anyway.
Attachment #8651246 - Flags: review?(ted)
Attachment #8651246 - Flags: review?(ted) → review+
You need to log in before you can comment on or make changes to this bug.