1197293 - fix bustage in taskcluster from upload-properties.json change

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Bug 1118778 landed some changes that fail if 'make upload' doesn't run:

https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/QbXW1DAmRYWB3beFk0ugow/0/public/logs/live_backing.log
17:20:22     INFO -  /home/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python /home/worker/workspace/build/src/build/gen_mach_buildprops.py --complete-mar-file dist/update/firefox-43.0a1.en-US.linux-x86_64.complete.mar  --upload-properties dist/upload-properties.json
17:20:22     INFO -  Traceback (most recent call last):
17:20:22     INFO -    File "/home/worker/workspace/build/src/build/gen_mach_buildprops.py", line 65, in <module>
17:20:22     INFO -      with open(args.upload_properties) as f:
17:20:22     INFO -  IOError: [Errno 2] No such file or directory: 'dist/upload-properties.json'

We don't do uploads in taskcluster, so indeed 'make upload' does not run.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Mike has offered to take a look at this

Comment 2

[Michael Shal [:mshal]]

Attachment: 0001-Bug-1197293-allow-for-TC-builds-that-don-t-use-make-.patch

Although mach_build_properties.json is largely useless for TC builds, it's a little trickier to have mozharness ignore that since it doesn't know the value of MOZ_AUTOMATION_UPLOAD. Though I may kill gen_mach_buildprops.py soon and just have upload.py output all the properties directly, so mozharness may need to treat it as an optional file then anyway.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16327a5d2961

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16327a5d2961