1197302 - Hello functional test fails because of missing button

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Nils Ohlmeier [:drno]]

Since 15.08.15 the functional tests are failing: http://10.252.73.218:8080/view/hello/job/hello-e2e-marionette/

With this error message:

TEST-UNEXPECTED-ERROR | test_1_browser_call.py Test1BrowserCall.test_1_browser_call | NoSuchElementException: NoSuchElementException: Unable to locate element: .rooms .btn-info
Traceback (most recent call last):
  File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_client-0.18-py2.7.egg/marionette/marionette_test.py", line 296, in run
    testMethod()
  File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/marionette/tests/browser/components/loop/test/functional/test_1_browser_call.py", line 228, in test_1_browser_call
    self.local_start_a_conversation()
  File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/marionette/tests/browser/components/loop/test/functional/test_1_browser_call.py", line 92, in local_start_a_conversation
    button = self.marionette.find_element(By.CSS_SELECTOR, ".rooms .btn-info")
  File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_driver-0.12-py2.7.egg/marionette_driver/marionette.py", line 1579, in find_element
    el = self._send_message("findElement", body, key="value")
  File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_driver-0.12-py2.7.egg/marionette_driver/decorators.py", line 36, in _
    return func(*args, **kwargs)
  File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_driver-0.12-py2.7.egg/marionette_driver/marionette.py", line 711, in _send_message
    self._handle_error(resp)
  File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_driver-0.12-py2.7.egg/marionette_driver/marionette.py", line 752, in _handle_error
    raise errors.lookup(error)(message, stacktrace=stacktrace)

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Fix Loop functional test

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Fix Loop functional test

Comment 3

[Andrei Oprea [:andreio]]

`Mark Banner (:standard8) (away until 24 Aug) <[e-mail]> is not currently accepting 'review' requests.` Please review my patch :)

Comment 4

[Ed Lee :Mardak]

Regressed from bug 1183638 where the new _renderNoRoomsView top level is div.room-list instead of div.rooms.

http://hg.mozilla.org/mozilla-central/rev/5c906eb9b8d9#l4.43

Should that top div for no-rooms also get .rooms?

Comment 5

[Andrei Oprea [:andreio]]

I don't think it's worth changing now that this patch already fixes it.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8651357 [details] [diff] [review]
Fix Loop functional test

Looks good.

I agree we don't need .rooms there - .rooms is slightly ambiguous anyway - I prefer the new class names better.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/efae032a3bc2

Comment 8

[Mark Banner (:standard8)]

I landed this in the tree to get the tests passing earlier. Note I also updated the check-in comment a bit to be more descriptive and to reference that this isn't part of the build, so that we can use DONTBUILD on it and avoid the unnecessary build cycles.

Comment 9

[Ed Lee :Mardak]

Sounds good. I wasn't sure if there was a pattern of making sure a given React Class exposes the same css class at its top level. Also, when there's no rooms, .room-list is a parent of the new room button but when there are rooms, .room-list is its previous sibling.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/efae032a3bc2