Closed
Bug 1197366
Opened 9 years ago
Closed 9 years ago
Suppress 404 errors for missing CSS
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox43 fixed)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: abr, Assigned: abr)
Details
Attachments
(1 file)
1.38 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Currently, all Hello page loads include an attempt to access https://hello.firefox.com/shared/libs/sdk-content//css/TB.min.css This results in extraneous 404 errors. We should override the toolkit CSS to prevent these errors from occuring.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Mark / Mike -- could you double-check that this works as expected, and land it?
Assignee: adam → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(standard8)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(mdeboer)
Comment 3•9 years ago
|
||
Comment on attachment 8651231 [details] [diff] [review] Suppress 404 errors for missing CSS Review of attachment 8651231 [details] [diff] [review]: ----------------------------------------------------------------- Sticking in my queue, should get to it today.
Attachment #8651231 -
Flags: review?(standard8)
Updated•9 years ago
|
Assignee: nobody → adam
Flags: needinfo?(standard8)
Flags: needinfo?(mdeboer)
Comment 4•9 years ago
|
||
Comment on attachment 8651231 [details] [diff] [review] Suppress 404 errors for missing CSS Review of attachment 8651231 [details] [diff] [review]: ----------------------------------------------------------------- r=me if you add the same to otconfig.js as well.
Attachment #8651231 -
Flags: review?(standard8) → review+
Comment 6•9 years ago
|
||
Adam: I landed this on your behalf as I was landing some other items as well.
Iteration: --- → 43.2 - Sep 7
Points: --- → 2
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #6) > Adam: I landed this on your behalf as I was landing some other items as well. Thanks!
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7d4f42f02512
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•