Closed
Bug 1197378
Opened 9 years ago
Closed 9 years ago
Enable docshell navigation tests for e10s
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: mrbkap, Assigned: mrbkap)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
5.47 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
test_bug13871.html is just flat out racy. It's amazing that it passes as consistently as it does on non-e10s Firefox.
Attachment #8651243 -
Flags: review?(wmccloskey)
Comment on attachment 8651243 [details] [diff] [review] Proposed fix Review of attachment 8651243 [details] [diff] [review]: ----------------------------------------------------------------- Cool, thanks. ::: docshell/test/navigation/test_bug13871.html @@ +35,5 @@ > +// We instead wait for a postMessage from parent.html. > +var windows = new Map(); > +addEventListener("message", function windowLoaded(evt) { > + // Because window.open spins the event loop in order to open new windows, > + // deal with races in whether we call waitForLoad before we get the message. I'm unable to parse this sentence.
Attachment #8651243 -
Flags: review?(wmccloskey) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0dcc8b43ed51
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•