Closed Bug 1197378 Opened 5 years ago Closed 5 years ago

Enable docshell navigation tests for e10s

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
e10s + ---
firefox43 --- fixed

People

(Reporter: mrbkap, Assigned: mrbkap)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attached patch Proposed fixSplinter Review
test_bug13871.html is just flat out racy. It's amazing that it passes as consistently as it does on non-e10s Firefox.
Attachment #8651243 - Flags: review?(wmccloskey)
Comment on attachment 8651243 [details] [diff] [review]
Proposed fix

Review of attachment 8651243 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks.

::: docshell/test/navigation/test_bug13871.html
@@ +35,5 @@
> +// We instead wait for a postMessage from parent.html.
> +var windows = new Map();
> +addEventListener("message", function windowLoaded(evt) {
> +  // Because window.open spins the event loop in order to open new windows,
> +  // deal with races in whether we call waitForLoad before we get the message.

I'm unable to parse this sentence.
Attachment #8651243 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/0dcc8b43ed51
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.