1197466 - Consistently format pushlog output

Status: RESOLVED FIXED

(Developer Services :: Mercurial: Pushlog, defect)

Description

[Gregory Szorc [:gps]]

The output from the pushlog extension when it inserts new data is inconsistent with the rest of Mercurial. The "recording push in pushlog..." message is also a bit excessive now that we have proper transaction support and don't need this confirmation.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: pushlog: change printed messages (bug 1197466); r?smacleod

pushlog: change printed messages (bug 1197466); r?smacleod

The messages that the pushlog extension prints during push are formatted
inconsistently with the rest of Mercurial. They have capital letters and
periods where other messages do not. Personally, I like the well-formed
sentences. But this isn't what upstream does. So we change the
formatting.

The "Trying to insert" message isn't necessary because both the success
and failure cases print a message. The only time this would be useful is
if there is some kind of hang opening the pushlog database. We've had no
reports of this happening and I see little value in retaining this
message. It has been removed.

The messages are leaking implementation details that the pushlog is
stored in a database. The wording has been changed to be more generic
and concise.

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8651342 [details]
MozReview Request: pushlog: change printed messages (bug 1197466); r?smacleod

https://reviewboard.mozilla.org/r/16941/#review15029

Ship It!

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/4c4cdc5dba4209ea21d97cc5f4d585c8d09248de
pushlog: change printed messages (bug 1197466); r=smacleod

Comment 4

[Gregory Szorc [:gps]]

Will likely push this out sometime Monday.