1197552 - Show an error notification if login fails

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Sami Jaktholm]

In few occasions I've managed to trigger CSRF verification failures while logging in to Treeherder which obviously causes the login to fail. Such cases include bug 1197550 and disabling referrers.

However if the login fails, the Treeherder UI does not give any indication about the failure. It'd be nice to get a notification about the failed login instead of having to monitor requests to see what is going on.

Comment 1

[Ed Morley [:emorley]]

Thank you for filing this - agree the current behaviour is suboptimal with no error message!

Comment 2

[Ed Morley [:emorley]]

Attachment: PR: Show a notification if login fails

Creating attachment on behalf of Sami, for PR#899.

Comment 3

[Jonathan French (:jfrench)]

Comment on attachment 8651812 [details] [review]
PR: Show a notification if login fails

r+ with nit addressed. I tried to think of a more communicative message that works with Persona, future OKTA and other invalid conditions, but agree it's probably simplest to just got with "Login failed:" for now :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/737ca0f6c43d1933f0285c652d314e45e0c34539
Bug 1197552 - Show a notification if Persona login fails

Comment 5

[Ed Morley [:emorley]]

This will be deployed to stage/prod sometime in the next few days. Thank you for the patch :-)