1197584 - ZNC server asks for password, also if it is configured

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[TheRave]

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150822030206

Steps to reproduce:

Tried to connect and saved the debug log files if somebody need these. Not sure if there are secret informations in this log file so i will provide it on request.

Account settings in password field is entered:
Nickname/Channel:mypassword

server url:
hosting.rikairchy.net

port:5050 ssl on

showed in account informations as [e-mail]


Actual results:

12:13:56 - *** You need to send your password. Configure your client to send a server password.
12:13:56 - *** To connect now, you can use /quote PASS <username>:<password>, or /quote PASS <username>/<network>:<password> to connect to a specific network.


Expected results:

Same settings are working in Miranda.

Comment 1

[aleth [:aleth]]

This can certainly be made to work. The issue is that there are two passwords on IRC - one for the server and one for nickserv. Users who don't run bouncers usually only ever need the second.

It may be helpful to use a current nightly - as far as I recall, there are some small improvements for bouncer users in there.

The discussion here should help configure this: http://blog.gerv.net/2015/01/using-instantbird-to-connect-to-irc-servers-requiring-a-username-and-password/

There are plans to improve the UI around this setup for bouncer users.

Comment 2

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #1)
> It may be helpful to use a current nightly - as far as I recall, there are
> some small improvements for bouncer users in there.

Actually, if you're using Thunderbird those improvements should already be in TB 38.

Comment 3

[TheRave]

Thank you for TB 38.2 it works now after i have done this settings manually:

messenger.account.accountN.options.serverPassword
messenger.account.accountN.options.username

Comment 4

[Patrick Cloke [:clokep]]

Setting those *should not* be necessary for ZNC.

What version of ZNC are yo using? It looks like our code to send the password automatically isn't working [1] because the received message is different.

[1] http://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircNonStandard.jsm#51

Comment 5

[TheRave]

It is ZNC - 1.7.x-git-118-9814f2a used by Stormbit. I can still send the logfiles if needed. It was working with the prevoius version (1.4?) and stopped to work after they upgraded their ZNC version. Miranda was working the entire time. In fact with the new settings its working now.

Comment 6

[Patrick Cloke [:clokep]]

TheRave, thanks for the detailed report! It looks like this was broken earlier this year by a ZNC commit: https://github.com/znc/znc/commit/26e466c677953313dce3ca98362025f9fa0b4cd2

aleth, what do you think of just using the 464 numeric to send this?

Comment 7

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #6)
> TheRave, thanks for the detailed report! It looks like this was broken
> earlier this year by a ZNC commit:
> https://github.com/znc/znc/commit/26e466c677953313dce3ca98362025f9fa0b4cd2
> 
> aleth, what do you think of just using the 464 numeric to send this?

It's simpler to change the check here
change this here to a .startsWith with only the first sentence https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/ircNonStandard.jsm#55
to a .startsWith with only the first sentence.

Comment 8

[Patrick Cloke [:clokep]]

Attachment: Patch v1

I can't actually test this since I don't have access to ZNC. I added a test though...

Comment 9

[aleth [:aleth]]

Comment on attachment 8655552 [details] [diff] [review]
Patch v1

Review of attachment 8655552 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this, until ZNC breaks it again ;)

Comment 10

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/35c170d18212a2056e2b5ccd30ce57b780cc4d48
Bug 1197584 - Handle newer ZNC auth requests. r=aleth