Closed Bug 1197619 Opened 4 years ago Closed 3 years ago

[Messages] Convert switch controls to use web components

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(2 files, 2 obsolete files)

In preparation for moving to web components.
Do gaia-checkbox look the same ?
(In reply to Julien Wajsberg [:julienw] from comment #2)
> Do gaia-checkbox look the same ?

Yes, they look the same. We are implementing web components everywhere with the same look and feel currently, so we can swap them out for the updated look and feel in the future. If you end up reviewing this - they should look and function as they do in master today.
Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

Julien - thank you for already taking a look at this. I think this is ready for a formal review if you have cycles to do so. Thanks!
Attachment #8651535 - Flags: review?(felash)
Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

So I agree that we don't see performance issues with the patch, and moreover it removes some monster CSS, so I'm more than happy to see this.

Some questions on github + some bugs and the integration tests to be changed :)
Attachment #8651535 - Flags: review?(felash) → feedback+
Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

Hi Julien,

I've addressed some questions, and fixed up the incoming message checkboxes. Please take a look when you get a chance.

I'm also wondering if perhaps Steve could take a look since you're on PTO. Thanks!
Attachment #8651535 - Flags: review?(schung)
Attachment #8651535 - Flags: review?(felash)
Sure I can take a look
Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

The only nit is about the value getter(I'm ok if we create another feature for the value getter), otherwise it looks great!
Attachment #8651535 - Flags: review?(schung) → review+
Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

Thanks for taking a look guys.

I've gone ahead and landed this for now, please let me know if you find any further issues with this and I'll be happy to try to fix them.

In master: https://github.com/mozilla-b2g/gaia/commit/5d6275e6c547e4816e8ea8fd4ec2b0f251fd77bf
Attachment #8651535 - Flags: review?(felash)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
It's possible that this is this bug, https://bugzilla.mozilla.org/show_bug.cgi?id=1179586

I didn't think so at first because the failure happened on both b2g desktop and mulet. Re-triggering to check.
Was it perma-red with your patch ?
(In reply to Julien Wajsberg [:julienw] (PTO Sept 2nd -> Sept 10th) from comment #14)
> Was it perma-red with your patch ?

Yes, perma-red, but only after landing to b-i, so likely something upstream changed (maybe in the test harness). I'll try to pinpoint it once gaia-try is working again and will re-request review if there are any substantial changes needed.
I submitted the same patch in a different pull request and tests pass, so I'm wondering if this wasn't something bad temporarily on b2g-inbound. You can see tests passing here: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e8a3a1c86d83bfac4ad2d9a01f4920f125189c87

Something strange is going on, and I might try landing this again.
Attachment #8660381 - Attachment is obsolete: true
good for me
Depends on: 1205806
Attachment #8662961 - Attachment is obsolete: true
Mass closing of Gaia::SMS bugs. End of an era :(
Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.