1197619 - [Messages] Convert switch controls to use web components

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Kevin Grandon :kgrandon]

In preparation for moving to web components.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Do gaia-checkbox look the same ?

Comment 3

[Kevin Grandon :kgrandon]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Do gaia-checkbox look the same ?

Yes, they look the same. We are implementing web components everywhere with the same look and feel currently, so we can swap them out for the updated look and feel in the future. If you end up reviewing this - they should look and function as they do in master today.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

Julien - thank you for already taking a look at this. I think this is ready for a formal review if you have cycles to do so. Thanks!

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

So I agree that we don't see performance issues with the patch, and moreover it removes some monster CSS, so I'm more than happy to see this.

Some questions on github + some bugs and the integration tests to be changed :)

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

Hi Julien,

I've addressed some questions, and fixed up the incoming message checkboxes. Please take a look when you get a chance.

I'm also wondering if perhaps Steve could take a look since you're on PTO. Thanks!

Comment 7

[Steve Chung [:steveck]]

Sure I can take a look

Comment 8

[Steve Chung [:steveck]]

Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

The only nit is about the value getter(I'm ok if we create another feature for the value getter), otherwise it looks great!

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8651535 [details] [review]
[gaia] KevinGrandon:bug_1197619_sms_checkbox_web_components > mozilla-b2g:master

Thanks for taking a look guys.

I've gone ahead and landed this for now, please let me know if you find any further issues with this and I'll be happy to try to fix them.

In master: https://github.com/mozilla-b2g/gaia/commit/5d6275e6c547e4816e8ea8fd4ec2b0f251fd77bf

Comment 10

[Kevin Grandon :kgrandon]

Gaia-try was green, but landing seems to have broken Gij16.

Backing out: https://github.com/mozilla-b2g/gaia/commit/2c6d22b87fc25e0f902a9ff5b9b81addd0ed631c

https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/VfLkRlk0SlmfZj-JC8tpnw/0/public/logs/live_backing.log

Comment 11

[Kevin Grandon :kgrandon]

It's possible that this is this bug, https://bugzilla.mozilla.org/show_bug.cgi?id=1179586

I didn't think so at first because the failure happened on both b2g desktop and mulet. Re-triggering to check.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1197619_reland > mozilla-b2g:master

Comment 13

[Kevin Grandon :kgrandon]

Failed run: https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=d2d908f25928

Comment 14

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Was it perma-red with your patch ?

Comment 15

[Kevin Grandon :kgrandon]

(In reply to Julien Wajsberg [:julienw] (PTO Sept 2nd -> Sept 10th) from comment #14)
> Was it perma-red with your patch ?

Yes, perma-red, but only after landing to b-i, so likely something upstream changed (maybe in the test harness). I'll try to pinpoint it once gaia-try is working again and will re-request review if there are any substantial changes needed.

Comment 16

[Kevin Grandon :kgrandon]

I submitted the same patch in a different pull request and tests pass, so I'm wondering if this wasn't something bad temporarily on b2g-inbound. You can see tests passing here: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e8a3a1c86d83bfac4ad2d9a01f4920f125189c87

Something strange is going on, and I might try landing this again.

Comment 17

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

good for me

Comment 18

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1197619_reland_again > mozilla-b2g:master

Comment 19

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1197619_reland > mozilla-b2g:master

Comment 20

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 21

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Mass closing of Gaia::SMS bugs. End of an era :(