Closed Bug 1197672 Opened 6 years ago Closed 6 years ago

mozInputMethod.addInput() shouldn't call _sendPromise() anymore

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
blocking-b2g 2.5+
Tracking Status
firefox43 --- fixed
b2g-master --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

(Keywords: regression)

Attachments

(1 file)

The patch in bug 904479 missed this one _sendPromise() call and only changed the one in removeInput().

https://hg.mozilla.org/mozilla-central/file/0f5421c28b14/dom/inputmethod/MozKeyboard.js#l384

Unfortunately both methods were not covered by tests because their end result is to cause mozChromeEvents to System app -- which is untestable in any of our test suites. I can't test the entire flow with Gij tests either because the flow (download the dictionary and enable it) involves external file download.

Let me submit a one-liner here and work on replacing these mozChromeEvents with events later.
blocking-b2g: --- → 2.5+
Attached patch PatchSplinter Review
Attachment #8651601 - Flags: review?(kchen)
Attachment #8651601 - Flags: review?(kchen) → review+
https://hg.mozilla.org/mozilla-central/rev/dd9b9887e889
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.