Closed Bug 1197672 Opened 7 years ago Closed 7 years ago
Input Method .add Input() shouldn't call _send Promise() anymore
The patch in bug 904479 missed this one _sendPromise() call and only changed the one in removeInput(). https://hg.mozilla.org/mozilla-central/file/0f5421c28b14/dom/inputmethod/MozKeyboard.js#l384 Unfortunately both methods were not covered by tests because their end result is to cause mozChromeEvents to System app -- which is untestable in any of our test suites. I can't test the entire flow with Gij tests either because the flow (download the dictionary and enable it) involves external file download. Let me submit a one-liner here and work on replacing these mozChromeEvents with events later.
Attachment #8651601 - Flags: review?(kchen) → review+
You need to log in before you can comment on or make changes to this bug.