Closed
Bug 1197672
Opened 10 years ago
Closed 10 years ago
mozInputMethod.addInput() shouldn't call _sendPromise() anymore
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
964 bytes,
patch
|
kanru
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 904479 missed this one _sendPromise() call and only changed the one in removeInput().
https://hg.mozilla.org/mozilla-central/file/0f5421c28b14/dom/inputmethod/MozKeyboard.js#l384
Unfortunately both methods were not covered by tests because their end result is to cause mozChromeEvents to System app -- which is untestable in any of our test suites. I can't test the entire flow with Gij tests either because the flow (download the dictionary and enable it) involves external file download.
Let me submit a one-liner here and work on replacing these mozChromeEvents with events later.
|
Assignee | |
Updated•10 years ago
|
blocking-b2g: --- → 2.5+
status-firefox43:
--- → affected
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8651601 -
Flags: review?(kchen)
|
||
Updated•10 years ago
|
Attachment #8651601 -
Flags: review?(kchen) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•10 years ago
|
Keywords: regression
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
|
||
Updated•10 years ago
|
status-b2g-master:
--- → fixed
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•