1197711 - [Bluetooth][Callscreen] BTReceiverIcon icon does not show correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[[e-mail]]

https://github.com/gasolin/gaia/blob/master/apps/callscreen/js/calls_handler.js#L52

Due to API migration, the `getConnectedDevicesByProfile` api is deprecated and have no replacement here.

Comment 1

[[e-mail]]

BTHelper only provide warning but not have the replacement
https://github.com/mozilla-b2g/gaia/blob/9dfedd7d35da00fa9b08dcffc3ab4f47da54e4f0/shared/js/bluetooth_helper.js#L177-L181

And theres no isscoConnected equivalent `ishfpConnected` api available in Gecko

Comment 2

[[e-mail]]

Since adapter.getConnectedDevices api is still exist, we could just remove the false alert

https://dxr.mozilla.org/mozilla-central/source/dom/webidl/BluetoothAdapter.webidl?from=BluetoothAdapter.webidl&offset=0#108

Comment 3

[[e-mail]]

[Blocking Requested - why for this release]: regression of BT APIv2 migration

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1197711 > mozilla-b2g:master

Comment 5

[[e-mail]]

Comment on attachment 8652132 [details] [review]
[gaia] gasolin:issue-1197711 > mozilla-b2g:master

francisco, since the `getConnectedDevicesByProfile` API is only called in callscreen
https://github.com/gasolin/gaia/blob/master/apps/callscreen/js/calls_handler.js#L52

Could you help review if it solve the issue.

The STR:
* pair bluetooth headphone (hfp denotes head phone profile)
* reboot and dial to this device
* see if icon has changed to headphone

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8652132 [details] [review]
[gaia] gasolin:issue-1197711 > mozilla-b2g:master

Redirecting to Gabriele.

Gabriele, can you find someone to help here?

Comment 7

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8652132 [details] [review]
[gaia] gasolin:issue-1197711 > mozilla-b2g:master

Redirecting the review to :drs since I've got a pretty long review queue right now.

Comment 8

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8652132 [details] [review]
[gaia] gasolin:issue-1197711 > mozilla-b2g:master

This change also impacts the Music and Settings apps, so we should flag peers of those modules for reviews as well. My guesses for these people would be :justindarc for Music, and :evelyn for Settings. This might be a bit pedantic, but I don't know this code very well. I am reviewing only for the Callscreen.

Please see my comment on the PR.

Comment 9

[Mahendra Potharaju [:mahe]]

Doug/Fred, Can you please provide a screen shot? Will help in 2.5 triage.

Comment 10

[[e-mail]]

Thanks for review. Though the change does not impact Music nor Settings app because they did not call `getConnectedDevicesByProfile` method(with Bluetooth APIv2). Callscreen is the only usecase.

Comment 11

[[e-mail]]

Comment on attachment 8652132 [details] [review]
[gaia] gasolin:issue-1197711 > mozilla-b2g:master

@evelyn could you help review the bluetooth helper?

also ask @jocelyn's feedback for proper use of BT APIv2

Comment 12

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8652132 [details] [review]
[gaia] gasolin:issue-1197711 > mozilla-b2g:master

Hi Fred,

We didn't revise this API in BT APIv2 development, there should be no difference in the API usage.

Thanks,
Jocelyn

Comment 13

[Evelyn Hung]

Comment on attachment 8652132 [details] [review]
[gaia] gasolin:issue-1197711 > mozilla-b2g:master

Thanks.

Comment 14

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/e9d7c4e3ede5ca1559d7375ac78a7f97d40dc414

thanks!