1197756 - Don't clone emulator kernel into all repositories

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Prebuilt emulator kernels are currently cloned into all targets for JB and later. We only actually need them on the emulator targets.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This should save ~150 MiB of disk space for any target that is not an emulator. :)

Comment 3

[Michael Wu [:mwu]]

Did you test this? I remember the build system depended on some file on here, emulator or not.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Arrg! Yeah, fails on flame-kk. :/

The dependency is hard-code, but it's only a single text file. [1] Can we create a branch with just this file?

[1] https://www.codeaurora.org/cgit/external/gigabyte/platform/build/tree/core/Makefile?h=caf/LA.AF.1.1.1#n645

Comment 5

[Michael Wu [:mwu]]

You could, but git downloads whole repositories so the download size would be unchanged. Creating a repo with just that file would do the trick. Alternately, you could try moving the file into platform_build.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8651724 [details] [review]
Github pull request

Looks good to me. As mwu suggested, a patch in platform_build[1] is needed to fix flame-kk build error.

[1] https://github.com/mozilla-b2g/platform_build/tree/b2g-4.4.2_r1

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github tree for qemu-kernel replacement

Named fake-qemu-kernel, in the tradition of fake-dalvik.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8652758 [details]
Github tree for qemu-kernel replacement

Flame-kk builds with this repository.

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8651724 [details] [review]
Github pull request

Reopening this for review, as the pull request changed significantly.

Comment 10

[Michael Wu [:mwu]]

Comment on attachment 8651724 [details] [review]
Github pull request

Some of these are pointing to b2g-* branches, which don't exist in your fake-qemu-kernel tree. I think we can just point everything to the master branch though, so r=me with that. Alternately, make additional branches.

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Michael,

could you please create 'mozilla-b2g/fake-qemu-kernel'? I don't have the necessary permission.

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8652758 [details]
Github tree for qemu-kernel replacement

>https://github.com/mozilla-b2g/fake-qemu-kernel

Comment 13

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github tree for qemu-kernel replacement

Equivalent to previous Github tree, but now points to mozilla-b2g; r=mwu

Comment 14

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/b2g-manifest/commit/04f2e29fc408b434256fa8cda76de2d78ac15798