119779 - Getting Javascript error (uncaught exception) when pressing the dropdown button in the OSCP list

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P2)

Description

[Henrik Gemal]

In the Prefs -> Privacy & Security -> Validation
if I select the 3 option  in OSCP and then press the dropdown button and select
an item I get:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIMenuBoxObject.activeChild]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: <unknown filename> ::
onxblpopupshowing :: line 6"  data: no]

20020111

Comment 1

[Stephane Saux]

I see that.  The xul and js for this dialog to not use nsIMenuBoxObject.activeChild

We have a menulist and we call the following methods on it:

  var CA = signersMenu.getAttribute("value");
signersMenu.firstChild.appendChild(menuItemNode);
signersMenu.setAttribute("disabled", true);
signersURL.removeAttribute("disabled")

I'll place try blocks to see which one of these calls generates the error. I
suspect that it's either getAttribute("value") or appendChild()

cc Hyatt in case this is a known xul issue.

Comment 2

[John Unruh]

nsbeta1

Comment 3

[Kai Engert [:KaiE:]]

While the dropdown list has other issues (like being to narrow to read the
entries), I can no longer reproduce this reported problem.

Resolving worksforme.

Comment 4

[Henrik Gemal]

still getting:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIMenuBoxObject.activeChild]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: <unknown filename> ::
onxblpopupshowing :: line 6"  data: no]

20020819

Comment 5

[Kai Engert [:KaiE:]]

Ok, you are right. But there is restriction to see this bug. It only happens on
first attempt.

If you ignore the error and still press ok, then open prefs again, and select
another entry from the list, the error does not appear again.


I don't think the code that Stephane mentions in comment 1 is causing the
problem, because that code is executed when the pane is loaded, but the
exception does not appear until you click the dropdown box.

Comment 6

[Kai Engert [:KaiE:]]

I'm unable to find the cause for this error. Assigning to XUL. Can you please
have a look?

Comment 7

[David Perry]

I get that same exception on the "From:" dropdown in Composer (Mozilla 1.0 on
Red Hat Linux 7.2), and also on the dropdown in a XUL application I'm making
(Mozilla 1.1 on a different RH7.2 box).

Comment 8

[David Perry]

Sorry to keep spamming the whiteboard, but I played around a bit and found a
partial solution.  I added these two lines to content/global/bindings/menulist.xml:

(starting at line 30)
      <handler event="popupshowing">
        <![CDATA[
+++     try {
          if (event.target.parentNode == this && this.selectedItem) {
            // Not ready for auto-setting the active child in hierarchies yet.
            // For now, only do this when the outermost menupopup opens.
            var menuBox =
this.boxObject.QueryInterface(Components.interfaces.nsIMenuBoxObject);
            menuBox.activeChild = this.selectedItem;
          }
+++     } catch(e) {}
        ]]>
      </handler>
    </handlers>

That prevented the error on my 1.0 Compose window popup. (I haven't tried it on
my Moz 1.1 box yet.)

There's probably an 'official' (or at least cleaner) way to handle this, but
it's a clue as to the cause of the problem.

HTH.  Again, sorry to keep bugging.

Comment 9

[Henrik Gemal]

is bug 106964 a dupe of this?

Comment 10

[Kai Engert [:KaiE:]]

*** Bug 106964 has been marked as a duplicate of this bug. ***

Comment 11

[Kai Engert [:KaiE:]]

dmose said:
that sounds like a XUL bug, ie in XUL itself.
you'll need to go read whatever code implements nsIMenuBoxObject

Comment 12

[Jeff Patterson]

I get the same error using 1.2.1 built on a linux Redhat box (Mozilla/5.0 (X11;
U; Linux i686; en-US; rv:1.2.1) Gecko/20021208)

Comment 13

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 14

[Nigel McFarlane]

worksforme in 1.7.

On my box, there's a separate problem with the drop-down not
widening enough and the list items reading like crap, but
that's not this bug.

- N.