1197852 - [Dialer] Call will be put on hold when answering a received a call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: AudioChannel, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
When the user receives a call and answers it the phone call will automatically be put on hold. The user can turn off the hold and it will stay off. the person who made the call will not be put on hold

Repro Steps:
1) Update a Aries to 20150824130216
2) Receive a call
3) Answer call
4) Observe hold status of call

Actual:
Call will be put on hold after answering

Expected:
It is expected that the call is not automatically put on hold

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150824130216
Gaia: d7fb5717d3e0153ac64af2c0d5c11079846d81c3
Gecko: ba43a48d3c52
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro frequency: 10/10
Link to failed test case: https://moztrap.mozilla.org/manage/case/1300/
See attached: video clip, logcat

Comment 1

[Johan Lorenzo [:jlorenzo]]

Smoketest blocker. A similar issue was fixed last Thursday (bug 1195805)

Comment 2

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
Build ID: 20150824030214
Gaia: cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gecko: 8a6045d14d6b
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Result:
The phone is on hold when answering a call
-----------------------------
This issue DOES NOT occur on a previous Aries 2.5.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150820203627
Gaia: c6705f739fb605031eb2a0b943ba55c64bee5a03
Gecko: 7a6cd1616542
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Result:
This phone is not on hold when answering a call.

Comment 3

[Duane Dixon [:ddixon]]

Mozilla Inbound Regression Window

Last Working 

Device: Flame Master
BuildID: 20150821072141
Gaia: c6705f739fb605031eb2a0b943ba55c64bee5a03
Gecko: bb070785cc9b5fe060217af2a600ad7f10e63258
Version: 43.0a1 (Master) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken 

Device: Flame Master
BuildID: 20150821075941
Gaia: c6705f739fb605031eb2a0b943ba55c64bee5a03
Gecko: 28fa968ea46ca3e232b8cfbb4a88e9a492e71b16
Version: 43.0a1 (Master) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Last Working Gaia and First Broken Gecko
Issue DOES occur here: 
Gaia: c6705f739fb605031eb2a0b943ba55c64bee5a03
Gecko: 28fa968ea46ca3e232b8cfbb4a88e9a492e71b16

Last Working Gecko and First Broken Gaia
Issue DOES NOT occur here: 
Gaia: c6705f739fb605031eb2a0b943ba55c64bee5a03
Gecko: bb070785cc9b5fe060217af2a600ad7f10e63258

Mozilla Inbound Pushlog (Gecko)
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bb070785cc9b5fe060217af2a600ad7f10e63258&tochange=28fa968ea46ca3e232b8cfbb4a88e9a492e71b16

Possible Cause:
Bug 1129882 - [B2G] Using the new audio channel design to manage the telephony's sound

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Alastor, can you take a look at this please? This might have been caused by the landing for bug 1129882. This is a smoketest blocker so we will need that landing backed out.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

There seems to be a lot going on here with this bug.

I am not sure but I think the last two checkins are probably the thing to backout :
https://hg.mozilla.org/mozilla-central/rev/847b57aaeff7
https://hg.mozilla.org/mozilla-central/rev/9c6fde246f6e

Having said that reviewing the log:
Bug 1129882 - backout 9c6fde246f6e and 847b57aaeff7 for causing 1193840 on a CLOSED TREE r=szchen, r=htsai
Bug 1129882 - Add mozInterrupt in telephony object. r=baku
Backed out changeset 6df9cef6b3ed (bug 1129882) for GU failures on a CLOSED TREE
Backed out changeset c17987dfa969 (bug 1129882)
Backed out changeset 3620404c8725 (bug 1129882)
Bug 1129882 - only send mozinterrupt when interrupt happens. r=baku.
Bug 1129882 - Create agent in telephony object. r=szchen, r=htsai
Bug 1129882 - add mozInterrupt in telephony object. r=baku
Bug 1129882 - create agent in telephony object. r=szchen r=hsinyi
Bug 1129882 - Add mozInterrupt in telephony object. r=baku
Bug 1129882 - Create agent in telephony object. r=szchen, r=htsai

I think it might be safest to have Alastor take a look.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Alastor, if you back out/fix the issue, can you spin a build for QA please to test it?

Comment 7

[Cola, OOO till Oct. 8th]

This bug also exists  in latest build of Flame master and Aries master (user&engineer) by the STR in Comment 0.

Actual results:Call will be put on hold after answering

Reproduce rate: 5/5

Device: Aries KK 2.5
Build ID               20150825010113
Gaia Revision          b441bde54293bea5254dc340845effe951fa3906
Gaia Date              2015-08-24 17:47:19
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/ef0614cdd437fadc77d7140bbc7d377a4121834a
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150825.004753
Firmware Date          Tue Aug 25 00:48:02 UTC 2015
Bootloader             s1

Device: Flame KK v2.5
Build ID               20150824150208
Gaia Revision          d7fb5717d3e0153ac64af2c0d5c11079846d81c3
Gaia Date              2015-08-24 10:07:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ba43a48d3c528cc956335793e02504e5ca2c149f
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150824.182403
Firmware Date          Mon Aug 24 18:24:15 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 8

[Alastor Wu [:alwu]]

Keep NI, I'll check it.

Comment 9

[Alastor Wu [:alwu]]

It seems that the telephony resumed fail, even if we already send the resume request.
I need to discuss this issue with RIL team people.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Fixed by backout.
https://hg.mozilla.org/mozilla-central/rev/f3df9cd1701f

Comment 11

[Ben Hsu [:HoPang]]

Per offline discussion, Alaster and I figured out that the resume request is blocked by TelephonyService and further induce this issue, since the modem cannot handle consecutive requests coming so fast after the previouse request. Now, we are still searching a better way to fix this issue.

Comment 12

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified as fixed on today's Aries dogfood debug as well as Flame. Following STR, the call is correctly connected without being put on hold.

Device: Aries 2.5
BuildID: 20150826051728
Gaia: c1ae9f02f2a9cfb89bf67aeea97e467c41c3362c
Gecko: f61c3cc0eb8b7533818e7379ccc063b611015d9d
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.5
BuildID: 20150826030209
Gaia: c1ae9f02f2a9cfb89bf67aeea97e467c41c3362c
Gecko: f61c3cc0eb8b7533818e7379ccc063b611015d9d
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 13

[Johan Lorenzo [:jlorenzo]]

Based on backout commit.