1197974 - Don't exit Gecko on Android even if there's no window

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't exit Gecko on Android even if there's no window (v1)

Gecko on Android follows the Android app model where it never stops
until it is killed by the system or told explicitly to quit. Therefore,
we should exit Gecko when there is no window or the last window is closed.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8652489 [details] [diff] [review]
Don't exit Gecko on Android even if there's no window (v1)

Review of attachment 8652489 [details] [diff] [review]:
-----------------------------------------------------------------

As we discussed, you'll need to fix the Browser:Quit implementation in browser.js, but that can be in another patch.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Force Gecko to exit when explicitly quitting (v1)

Currently we "quit" by closing the last window, but this bug makes us
not quit Gecko automatically when the last window closes. Therefore we
should force Gecko to quit. This patch also makes our quit code
consistent with the addon restart code at [1], i.e. using
nsIAppShell::Quit to quit and sending the "quit-application-requested"
notification. The previous notification,
"browser-lastwindow-close-requested", appears to only be used on
desktop.

[1] mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js?rev=f61c3cc0eb8b#6287

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8652980 [details] [diff] [review]
Force Gecko to exit when explicitly quitting (v1)

I wonder if we should add telemetry for some of our "quit" code paths. It might be nice to know if any of them are ever used. We have a STARTUP enum telemetry probe in Java.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/007b7970b6c8
https://hg.mozilla.org/integration/mozilla-inbound/rev/e13fd468953b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/007b7970b6c8
https://hg.mozilla.org/mozilla-central/rev/e13fd468953b