119802 - Show Source on page does not 're-use' source window as in NS 4

Status: RESOLVED EXPIRED

(Core Graveyard :: View Source, defect)

Description

[Bishop Clark (LC957)]

View a source on a web page, by hitting CTRL-U.  Hit CTRL-U again.

In NS4:
 - it re-loads the source window before one's very eyes.

In Moz (build 2002011103) :
 - it opens ANOTHER, identical source window.

This is an inconsistency int he two versions, and a right pain when editing php
code!

(Moz thinks it's "Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+)
Gecko/20020111" cool, huh?)

Comment 1

[R.K.Aa.]

*** This bug has been marked as a duplicate of 55583 ***

Comment 2

[R.K.Aa.]

Reporter commented in mail this being wrongly duped. And so it is.
Reopening..

Comment 3

[Doron Rosenberg (IBM)]

xpapps

Comment 4

[Doron Rosenberg (IBM)]

What the reporter means is:

In 4.x, open mozilla.org. View its source. Go to another site and view its
source. It loads the 2nd page's source into the viewsource window that had the
mozilla.org source.

Now, I'm not sure if we want this behaviour or not, as for evangelism I usually
have multiple viewosurce windows open.

Comment 5

[timeless]

arg this is complicated. if you go to another page you'll get another window. 
trust me.

if you view source at the same page you won't. i'm not quite sure how same is 
defined, and don't have the energy to build a wysiwyg://1/javascript: test 
suite to prove to myself the definition of same.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Looks like NS4 just keys off the URL.  I'll try to play with this later today.

Comment 7

[Boris Zbarsky [:bzbarsky]]

NS4 does indeed just key off the URL.  I'm not convinced that this is a good
behavior, though. To UI design to make a decision.  mpt, once you make your
call, just reassign it to me, ok?

Comment 8

[Bishop Clark (LC957)]

I don't understand.  What's the drawbacks?  I'm sure there are some, but I can't
think of them.

Comment 9

[Boris Zbarsky [:bzbarsky]]

An obvious drawback is the case when you want the same page source in two
different windows.  Eg when you are reading HTML in one and script in the other
and want to refer back and forth without scrolling all the time.

Comment 10

[Peter Trudelle]

NS 4.x behavior uses the principals of doing the least work, and avoiding
duplication, which also corresonds nicely to typical usage cases.  In most cases
pages with the same URL will be the same source, so it is more efficient to
re-use the source window already displayed. This also avoids nasty surprises due
to having two separate snapshots in time of the page, with different source -
which is correct? The edge cases where you're expecting the page behind the URL
to change, or you want to view two copies of the same source, are obscure, and
not worth complicating the simplicity of having exactly one page source window
per url.  
Doron, isn't this your area?

Comment 11

[Boris Zbarsky [:bzbarsky]]

OK.  Since Peter and mpt agree on this one, we should try to fix it.... 
Unfortunately, openDialog is broken (bug 25040).

Taking this; will try to think of ways to work around openDialog brokenness...

Comment 12

[Boris Zbarsky [:bzbarsky]]

retargeting to a more realisting milestone...

Comment 13

[Boris Zbarsky [:bzbarsky]]

No plans to work on this any time in the foreseeable future, so to default owner.

Comment 14

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 15

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420