119812 - javascript strict warnings in CookieViewer.js

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Henrik Gemal]

When I remove a cookie from Cookie Manager

Warning: reference to undefined property cookies[idx]
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 173

build 20020111

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

I get both of these (this bug and 120277) at the same time.  Duping up.

*** This bug has been marked as a duplicate of 120277 ***

Comment 2

[Stephen P. Morse]

I wish you wouldn't dup them.  The symptoms are entirely different.

What if I determine that one report is invalid and I fix the other.  Do I close 
the bug report out as invalid or fixed?  What if I have to reassign one of them 
to another person.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Morse: sorry.  Some other owners prefer to dupe strict warnings into one patch.
I won't do it again!

Comment 4

[Stephen P. Morse]

Am unable to reproduce.  tever, can you reproduce this one?

Comment 5

[Henrik Gemal]

getting this every time I delete a cookie from the Cookie Manager.
And you do have strict warn on and everything?

Comment 6

[Stephen P. Morse]

Yes, I do have strict warn on.  Is that "everything"?

Comment 7

[Henrik Gemal]

please try this to reproduce:
1) use a fresh new profile
2) enable js strict warns
3) go to http://opasia.dk
4) open js console
5) open cookie manager
6) select of of the two cookies and press Remove Cookie
7) watch the js console...

Warning: reference to undefined property cookies[idx]
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 241

Comment 8

[Stephen P. Morse]

OK, now I can reproduce.

Comment 9

[Stephen P. Morse]

Not sure exactly why this is happening.  When the CookieSelected() method of 
CookieViewer.js is entered, the value of selections[0] (i.e., the first element 
in the selections array) has a value greater than the number of elements in the 
cookie list.

So where is this call to CookieSelected() occuring?  It is happening in the 
DeleteSelectedItemFromOutliner() method in nsWalletTreeUtils.js.  Specifically 
it is happening just after the following line is executed:

     box.rowCountChanged(0, table.length);

This is to be expected.  However if I dump out the value of the first element in 
the selections array just prior to this statement, it is a valid value.

So it looks like some sort of synchronization problem.  The easiest thing to do 
here is just add some bulletproofing to catch this lack of synchronization.

Comment 10

[Stephen P. Morse]

Attachment: Add bulletproofing

Comment 11

[Stephen P. Morse]

alecf, sgehani, please review.  Thanks.

Comment 12

[Alec Flett]

Comment on attachment 69689 [details] [diff] [review]
Add bulletproofing

let's put a dump() in there to encourage people to help you track it down....

Comment 13

[Stephen P. Morse]

Attachment: Added dump statement per reviewer's request

Comment 14

[Samir Gehani]

Does this out-of-sync stat cause loss of functionality?  Would using a timeout
be helpful here (i.e., setTimeout(<func>, 0))?  Should we try and understand the
underlying issue so that other clients could benefit?

Comment 15

[Alec Flett]

Comment on attachment 69697 [details] [diff] [review]
Added dump statement per reviewer's request

sr=alecf

Comment 16

[Stephen P. Morse]

No, it doesn't cause loss of functionality.  There is another pending call to 
CookieSelected() that will occur just after this one, and that one has a valid 
value.  So it will perform the desired functions.

It's not worth investigating the underlying cause at this time because we have 
bigger fish to fry.

Comment 17

[Samir Gehani]

Comment on attachment 69697 [details] [diff] [review]
Added dump statement per reviewer's request

r=sgehani

Comment 18

[Stephen P. Morse]

Patch checked in.

Comment 19

[Henrik Gemal]

v 20020221

Comment 20

[Geraint]

If this bug was fixed in Feb 2002 why do I still get the dump message in
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020826.

"Tree and viewer state are out of sync! Help us figure out the problem in bug
119812D"

If it really is fixed why not drop the dump message.

By the way I got the message trying to delete a 2nd cookie from a site I had
blocked when I deleted the first !