Closed
Bug 1198326
Opened 9 years ago
Closed 8 years ago
[Rule View] Clicking on the selector input editor will blur the editor
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: gl, Assigned: jdescottes)
References
Details
Attachments
(1 file, 4 obsolete files)
6.18 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Edit the Selector 2. Click on the selector input editor. 3. It blurs! Expected: The input caret should select wherever my click is
Reporter | ||
Comment 1•9 years ago
|
||
Assignee: nobody → gabriel.luong
Status: NEW → ASSIGNED
Attachment #8653930 -
Flags: review?(pbrosset)
Reporter | ||
Comment 2•9 years ago
|
||
Attachment #8653930 -
Attachment is obsolete: true
Attachment #8653930 -
Flags: review?(pbrosset)
Attachment #8654266 -
Flags: review?(bgrinstead)
Comment 3•9 years ago
|
||
Comment on attachment 8654266 [details] [diff] [review] 1198326.patch [1.0] Review of attachment 8654266 [details] [diff] [review]: ----------------------------------------------------------------- Inplace editor changes = something might break. Make sure you run this through the test harness and do some smoke testing with various situations in the rule view. The only thing that looks like it might have some relation to this is https://dxr.mozilla.org/mozilla-central/source/browser/devtools/shared/inplace-editor.js#146 ::: browser/devtools/shared/inplace-editor.js @@ +244,5 @@ > } > this.input.addEventListener("blur", this._onBlur, false); > this.input.addEventListener("keypress", this._onKeyPress, false); > this.input.addEventListener("input", this._onInput, false); > + this.input.addEventListener("dblclick", e => e.stopPropagation(), false); Should these event listeners be removed? For some reason they never were even though blur/keypress/input/keyup are.
Attachment #8654266 -
Flags: review?(bgrinstead) → review+
Is bug 1197200 a duplicate of this? That bug is a regression between 41 and 42
See Also: → 1197200
Reporter | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e0ea874ec56
Attachment #8654266 -
Attachment is obsolete: true
Attachment #8697057 -
Flags: review?(bgrinstead)
Comment 6•8 years ago
|
||
Comment on attachment 8697057 [details] [diff] [review] 1198326.patch [2.0] Review of attachment 8697057 [details] [diff] [review]: ----------------------------------------------------------------- Works for me if existing tests pass. Can you please add a test case in one of the existing inplace editor tests?
Attachment #8697057 -
Flags: review?(bgrinstead) → feedback+
Reporter | ||
Updated•8 years ago
|
Assignee: gl → jdescottes
Assignee | ||
Comment 7•8 years ago
|
||
Readapted the patch from Gabriel and added one test case. Try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1e18cd95cac
Attachment #8697057 -
Attachment is obsolete: true
Attachment #8709608 -
Flags: review?(bgrinstead)
Comment 8•8 years ago
|
||
Comment on attachment 8709608 [details] [diff] [review] bug1198326.v3.patch Review of attachment 8709608 [details] [diff] [review]: ----------------------------------------------------------------- Nice, seems to fix it for me! ::: devtools/client/inspector/rules/test/browser_rules_edit-selector-click.js @@ +3,5 @@ > + http://creativecommons.org/publicdomain/zero/1.0/ */ > + > +"use strict"; > + > +// Testing selector inplace-editor behaviors in the rule-view with invalid This comment doesn't match up with what the test is doing
Attachment #8709608 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Thanks for the catch! Carry over r+ from previous review.
Attachment #8709608 -
Attachment is obsolete: true
Attachment #8709748 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/41efc3cbf8d6
Keywords: checkin-needed
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/41efc3cbf8d6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 14•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED --> VERIFIED Component: Name Firefox Version 46.0b2 Build ID 20160314144540 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Actual Results: As expected Expected Results: The input caret should select wherever my click is.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•