1198326 - [Rule View] Clicking on the selector input editor will blur the editor

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

STR:
1. Edit the Selector
2. Click on the selector input editor.
3. It blurs!

Expected:
The input caret should select wherever my click is

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1198326.patch

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1198326.patch [1.0]

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8654266 [details] [diff] [review]
1198326.patch [1.0]

Review of attachment 8654266 [details] [diff] [review]:
-----------------------------------------------------------------

Inplace editor changes = something might break.  Make sure you run this through the test harness and do some smoke testing with various situations in the rule view.  The only thing that looks like it might have some relation to this is https://dxr.mozilla.org/mozilla-central/source/browser/devtools/shared/inplace-editor.js#146

::: browser/devtools/shared/inplace-editor.js
@@ +244,5 @@
>    }
>    this.input.addEventListener("blur", this._onBlur, false);
>    this.input.addEventListener("keypress", this._onKeyPress, false);
>    this.input.addEventListener("input", this._onInput, false);
> +  this.input.addEventListener("dblclick", e => e.stopPropagation(), false);

Should these event listeners be removed?  For some reason they never were even though blur/keypress/input/keyup are.

Comment 4

[arni2033]

Is bug 1197200 a duplicate of this? That bug is a regression between 41 and 42

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1198326.patch [2.0]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e0ea874ec56

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8697057 [details] [diff] [review]
1198326.patch [2.0]

Review of attachment 8697057 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me if existing tests pass. Can you please add a test case in one of the existing inplace editor tests?

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: bug1198326.v3.patch

Readapted the patch from Gabriel and added one test case.

Try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1e18cd95cac

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8709608 [details] [diff] [review]
bug1198326.v3.patch

Review of attachment 8709608 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, seems to fix it for me!

::: devtools/client/inspector/rules/test/browser_rules_edit-selector-click.js
@@ +3,5 @@
> + http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +"use strict";
> +
> +// Testing selector inplace-editor behaviors in the rule-view with invalid

This comment doesn't match up with what the test is doing

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: bug1198326.v4.patch

Thanks for the catch!

Carry over r+ from previous review.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/41efc3cbf8d6

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41efc3cbf8d6

Comment 14

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED --> VERIFIED

Component: 
Name 	        Firefox
Version 	46.0b2
Build ID 	20160314144540
Update Channel 	beta
User Agent 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS              Windows 7 SP1 x86_64

Actual Results: 
As expected

Expected Results: 
The input caret should select wherever my click is.