Closed
Bug 1198339
Opened 9 years ago
Closed 9 years ago
Bind F1 key to open the settings when the toolbox is focused
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox43 fixed, relnote-firefox 43+)
RESOLVED
FIXED
Firefox 43
People
(Reporter: canuckistani, Assigned: bgrins)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [polish-backlog][chrome-parity])
Attachments
(2 files)
This work in chrome, it's convenient, doesn't seem to be bound to anything right now.
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Jeff Griffiths (:canuckistani) from comment #1) > bgrins: Good first bug? Yeah, so we already have a key for this - looks like ctrl+shift+O: https://dxr.mozilla.org/mozilla-central/source/browser/devtools/framework/toolbox.xul?offset=0#29 and https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/toolbox.dtd#14. Should we just change that to F1?
Flags: needinfo?(jgriffiths)
Reporter | ||
Comment 3•9 years ago
|
||
I think we should bind both to cover win/linux users with F keys by default, OS X users who enable access to the F keys and other OS X users who for some reason don't enable the F row. See also bug 1198404 - I think the binding should toggle the settings
Flags: needinfo?(jgriffiths)
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1198339 - Bind F1 key to open the settings when the toolbox is focused;r=jryans
Attachment #8654413 -
Flags: review?(jryans)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Comment on attachment 8654413 [details] MozReview Request: Bug 1198339 - Bind F1 key to open the settings when the toolbox is focused;r=jryans https://reviewboard.mozilla.org/r/17685/#review15909 ::: browser/devtools/framework/toolbox.xul:34 (Diff revision 1) > + keycode="VK_F1" Should we allow this to be localized via .dtd like the others?
Attachment #8654413 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5) > Comment on attachment 8654413 [details] > MozReview Request: Bug 1198339 - Bind F1 key to open the settings when the > toolbox is focused;r=jryans > > https://reviewboard.mozilla.org/r/17685/#review15909 > > ::: browser/devtools/framework/toolbox.xul:34 > (Diff revision 1) > > + keycode="VK_F1" > > Should we allow this to be localized via .dtd like the others? I wondered the same thing, but didn't do it just because there seemed to be some precedent for putting it in xul vs a dtd file: https://dxr.mozilla.org/mozilla-central/search?q=path%3A*.xul+%27%22vk_f1%22%27&redirect=true&case=false&limit=60&offset=0 https://dxr.mozilla.org/mozilla-central/search?q=path%3A*.dtd+%27%22vk_f1%22%27&redirect=true&case=false&limit=58&offset=0 Small sample size, but scratchpad and page info dialog for instance just use F1. I'm not sure the best approach, I'll ask in #l10n.
Assignee | ||
Comment 7•9 years ago
|
||
Axel, should the 'F1' key code for attaching to a help command be put in a dtd file or is that universal enough to leave it in a <key> element directly? See also Comment 6
Flags: needinfo?(l10n)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8654413 [details] MozReview Request: Bug 1198339 - Bind F1 key to open the settings when the toolbox is focused;r=jryans Bug 1198339 - Bind F1 key to open the settings when the toolbox is focused;r=jryans
Assignee | ||
Comment 9•9 years ago
|
||
Bug 1198404 - Keyboard shortcut for options panel should toggle if it's already selected;r=jryans
Attachment #8655150 -
Flags: review?(jryans)
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #9) > Created attachment 8655150 [details] > MozReview Request: Bug 1198404 - Keyboard shortcut for options panel should > toggle if it's already selected;r=jryans > > Bug 1198404 - Keyboard shortcut for options panel should toggle if it's > already selected;r=jryans Hmm that didn't work. Wanted this review request to go to Bug 1198404
Comment on attachment 8655150 [details] MozReview Request: Bug 1198404 - Keyboard shortcut for options panel should toggle if it's already selected;r=jryans https://reviewboard.mozilla.org/r/17847/#review15923
Attachment #8655150 -
Flags: review?(jryans) → review+
Comment 12•9 years ago
|
||
I guess the right way to do this is to reuse openHelp.commandkey from toolkit. Which is F1 in all locales, though, https://transvision.mozfr.org/string/?entity=toolkit/chrome/global/globalKeys.dtd:openHelp.commandkey&repo=aurora
Flags: needinfo?(l10n)
Assignee | ||
Comment 14•9 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #12) > I guess the right way to do this is to reuse openHelp.commandkey from > toolkit. > > Which is F1 in all locales, though, > https://transvision.mozfr.org/string/?entity=toolkit/chrome/global/ > globalKeys.dtd:openHelp.commandkey&repo=aurora Alright, reused the openHelp.commandkey for this shortcut
Comment 15•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20da43d2f599
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Assignee | ||
Updated•9 years ago
|
Keywords: dev-doc-needed
Comment 16•9 years ago
|
||
Release Note Request (optional, but appreciated) [Why is this notable]: suggested by dev tools team for aurora notes [Suggested wording]: Bind F1 key to open the settings when the toolbox is focused [Links (documentation, blog post, etc)]:
relnote-firefox:
--- → 43+
Comment 17•9 years ago
|
||
I've noted this in: https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts#Toolbox https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox#Settings_2 OK?
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 18•9 years ago
|
||
(In reply to Will Bamberg [:wbamberg] from comment #17) > I've noted this in: > https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts#Toolbox > https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox#Settings_2 > > OK? Thanks, see my note in https://bugzilla.mozilla.org/show_bug.cgi?id=1198404#c12
Flags: needinfo?(bgrinstead)
Updated•9 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•