Closed Bug 1198339 Opened 7 years ago Closed 7 years ago

Bind F1 key to open the settings when the toolbox is focused

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(firefox43 fixed, relnote-firefox 43+)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed
relnote-firefox --- 43+

People

(Reporter: canuckistani, Assigned: bgrins)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [polish-backlog][chrome-parity])

Attachments

(2 files)

This work in chrome, it's convenient, doesn't seem to be bound to anything right now.
bgrins: Good first bug?
Whiteboard: [polish-backlog][chrome-parity]
(In reply to Jeff Griffiths (:canuckistani) from comment #1)
> bgrins: Good first bug?

Yeah, so we already have a key for this - looks like ctrl+shift+O: https://dxr.mozilla.org/mozilla-central/source/browser/devtools/framework/toolbox.xul?offset=0#29 and https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/toolbox.dtd#14.

Should we just change that to F1?
Flags: needinfo?(jgriffiths)
See Also: → 1198404
I think we should bind both to cover win/linux users with F keys by default, OS X users who enable access to the F keys and other OS X users who for some reason don't enable the F row.

See also bug 1198404 - I think the binding should toggle the settings
Flags: needinfo?(jgriffiths)
Bug 1198339 - Bind F1 key to open the settings when the toolbox is focused;r=jryans
Attachment #8654413 - Flags: review?(jryans)
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Blocks: 1198404
See Also: 1198404
Comment on attachment 8654413 [details]
MozReview Request: Bug 1198339 - Bind F1 key to open the settings when the toolbox is focused;r=jryans

https://reviewboard.mozilla.org/r/17685/#review15909

::: browser/devtools/framework/toolbox.xul:34
(Diff revision 1)
> +         keycode="VK_F1"

Should we allow this to be localized via .dtd like the others?
Attachment #8654413 - Flags: review?(jryans) → review+
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> Comment on attachment 8654413 [details]
> MozReview Request: Bug 1198339 - Bind F1 key to open the settings when the
> toolbox is focused;r=jryans
> 
> https://reviewboard.mozilla.org/r/17685/#review15909
> 
> ::: browser/devtools/framework/toolbox.xul:34
> (Diff revision 1)
> > +         keycode="VK_F1"
> 
> Should we allow this to be localized via .dtd like the others?

I wondered the same thing, but didn't do it just because there seemed to be some precedent for putting it in xul vs a dtd file:

https://dxr.mozilla.org/mozilla-central/search?q=path%3A*.xul+%27%22vk_f1%22%27&redirect=true&case=false&limit=60&offset=0
https://dxr.mozilla.org/mozilla-central/search?q=path%3A*.dtd+%27%22vk_f1%22%27&redirect=true&case=false&limit=58&offset=0

Small sample size, but scratchpad and page info dialog for instance just use F1.  I'm not sure the best approach, I'll ask in #l10n.
Axel, should the 'F1' key code for attaching to a help command be put in a dtd file or is that universal enough to leave it in a <key> element directly?  See also Comment 6
Flags: needinfo?(l10n)
Comment on attachment 8654413 [details]
MozReview Request: Bug 1198339 - Bind F1 key to open the settings when the toolbox is focused;r=jryans

Bug 1198339 - Bind F1 key to open the settings when the toolbox is focused;r=jryans
Bug 1198404 - Keyboard shortcut for options panel should toggle if it's already selected;r=jryans
Attachment #8655150 - Flags: review?(jryans)
(In reply to Brian Grinstead [:bgrins] from comment #9)
> Created attachment 8655150 [details]
> MozReview Request: Bug 1198404 - Keyboard shortcut for options panel should
> toggle if it's already selected;r=jryans
> 
> Bug 1198404 - Keyboard shortcut for options panel should toggle if it's
> already selected;r=jryans

Hmm that didn't work.  Wanted this review request to go to Bug 1198404
Comment on attachment 8655150 [details]
MozReview Request: Bug 1198404 - Keyboard shortcut for options panel should toggle if it's already selected;r=jryans

https://reviewboard.mozilla.org/r/17847/#review15923
Attachment #8655150 - Flags: review?(jryans) → review+
I guess the right way to do this is to reuse openHelp.commandkey from toolkit.

Which is F1 in all locales, though, https://transvision.mozfr.org/string/?entity=toolkit/chrome/global/globalKeys.dtd:openHelp.commandkey&repo=aurora
Flags: needinfo?(l10n)
(In reply to Axel Hecht [:Pike] from comment #12)
> I guess the right way to do this is to reuse openHelp.commandkey from
> toolkit.
> 
> Which is F1 in all locales, though,
> https://transvision.mozfr.org/string/?entity=toolkit/chrome/global/
> globalKeys.dtd:openHelp.commandkey&repo=aurora

Alright, reused the openHelp.commandkey for this shortcut
https://hg.mozilla.org/mozilla-central/rev/20da43d2f599
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Keywords: dev-doc-needed
Release Note Request (optional, but appreciated)
[Why is this notable]: suggested by dev tools team for aurora notes
[Suggested wording]:  Bind F1 key to open the settings when the toolbox is focused
[Links (documentation, blog post, etc)]:
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.