1198352 - WeakSet methods are missing CallNonGenericMethod

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[André Bargull [:anba]]

Test case:
---
newGlobal().WeakSet.prototype.add.call(new WeakSet, {});
---


Expected: No error 
Actual: "TypeError: WeakSet.prototype.add called on incompatible object"

Comment 1

[Tom S [:evilpie]]

Attachment: Handle cross-compartment WeakSets

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8676409 [details] [diff] [review]
Handle cross-compartment WeakSets

Review of attachment 8676409 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing back because I can't type well and so should do less-typy things.

::: js/src/builtin/WeakSet.js
@@ +6,5 @@
>  function WeakSet_add(value) {
>      // Steps 1-3.
>      var S = this;
>      if (!IsObject(S) || !IsWeakSet(S))
> +        return callFunction(CallWeakSetMethodIfWrapped, this, value, "WeakSet_add");

If memory serves and the last string goes into user-visible error messages, make this "WeakSet.prototype.add", and so on for the others.  The "_" name is internal, shouldn't be mentioned.

Comment 3

[Tom S [:evilpie]]

Comment on attachment 8676409 [details] [diff] [review]
Handle cross-compartment WeakSets

Review of attachment 8676409 [details] [diff] [review]:
-----------------------------------------------------------------

I am not going to complain about a quick review :)

::: js/src/builtin/WeakSet.js
@@ +6,5 @@
>  function WeakSet_add(value) {
>      // Steps 1-3.
>      var S = this;
>      if (!IsObject(S) || !IsWeakSet(S))
> +        return callFunction(CallWeakSetMethodIfWrapped, this, value, "WeakSet_add");

This is actually how CallWeakSetMethodIfWrapped knows what to invoke.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc1467aff5e4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc1467aff5e4