1198385 - Use MFBT guard macros in the editor guard objects

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Comment 1

[(no longer active)]

Attachment: Use MFBT guard macros in the editor guard objects

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8652458 [details] [diff] [review]
Use MFBT guard macros in the editor guard objects

Review of attachment 8652458 [details] [diff] [review]:
-----------------------------------------------------------------

Please add #include "mozilla/GuardObjects.h" to nsEditorUtils.h.

::: editor/libeditor/nsEditorUtils.cpp
@@ +110,2 @@
>  {
> +  MOZ_GUARD_OBJECT_NOTIFIER_INIT;

IIUC, this should be:

  nsDOMSubtreeIterator::nsDOMSubtreeIterator(...)
    : nsDOMIterator(MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)
  {
  }

::: editor/libeditor/nsEditorUtils.h
@@ +214,5 @@
>  };
>  
>  class MOZ_STACK_CLASS nsDOMSubtreeIterator : public nsDOMIterator
>  {
> +  MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER

I don't think you need this, because nsDOMIterator already has one.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1904a234e142

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://treeherder.mozilla.org/logviewer.html#?job_id=13286912&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/57a3cadc3990

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/63431f8eca5b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Since you're apparently around but not on IRC, you have static analysis bustage now.
https://treeherder.mozilla.org/logviewer.html#?job_id=13287410&repo=mozilla-inbound

I'll backout in a few minutes if a follow-up doesn't magically appear.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0299179cab8b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63431f8eca5b
https://hg.mozilla.org/mozilla-central/rev/0299179cab8b