Closed Bug 1198385 Opened 10 years ago Closed 10 years ago

Use MFBT guard macros in the editor guard objects

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

No description provided.
See Also: → 1170484
Comment on attachment 8652458 [details] [diff] [review] Use MFBT guard macros in the editor guard objects Review of attachment 8652458 [details] [diff] [review]: ----------------------------------------------------------------- Please add #include "mozilla/GuardObjects.h" to nsEditorUtils.h. ::: editor/libeditor/nsEditorUtils.cpp @@ +110,2 @@ > { > + MOZ_GUARD_OBJECT_NOTIFIER_INIT; IIUC, this should be: nsDOMSubtreeIterator::nsDOMSubtreeIterator(...) : nsDOMIterator(MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT) { } ::: editor/libeditor/nsEditorUtils.h @@ +214,5 @@ > }; > > class MOZ_STACK_CLASS nsDOMSubtreeIterator : public nsDOMIterator > { > + MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER I don't think you need this, because nsDOMIterator already has one.
Attachment #8652458 - Flags: review?(nfroyd) → review+
Since you're apparently around but not on IRC, you have static analysis bustage now. https://treeherder.mozilla.org/logviewer.html#?job_id=13287410&repo=mozilla-inbound I'll backout in a few minutes if a follow-up doesn't magically appear.
Assignee: nobody → ehsan
Flags: needinfo?(ehsan)
Flags: needinfo?(ehsan)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: