1198450 - [e10s] Firefox fails to load "about:home" if Firefox was installed to a folder with non-Latin name

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alice0775 White]

The problem does not happen when disabled e10s.

Steps To Reproduce:
1. Install Firefox to to a folder with non-Latin name such as "ファイアフォックス"
2. Launch Firefox
3. Try open about:home

Actual Results:
An error page is loaded.
 
  !The address isn't valid
    The URL is not valid and cannot be loaded.
    ・Web addresses are usually written like http://www.example.com/
    ・Make sure that you're using forward slashes (i.e. /).
     [ Try Agan ]

Expected Results:
about:home should be shown.

Comment 1

[Alice0775 White]

The failure happens if non-Latin character was included in the installed path.

Comment 2

[atlanto]

Attachment: screenshot of ProcessExplorer

"-appdir" in command line for plugin-container.exe is broken.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: no_native_path_win.patch

as the commented out warning says[1] "This API is lossy. Use GetPath !"

1 http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsLocalFileWin.cpp#3443

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8691085 [details] [diff] [review]
no_native_path_win.patch

Review of attachment 8691085 [details] [diff] [review]:
-----------------------------------------------------------------

PerformAsyncLaunchInternal really needs to be broken down by platform. Total ifdef nightmare.

::: ipc/glue/GeckoChildProcessHost.cpp
@@ +546,5 @@
> +        MOZ_ALWAYS_TRUE(NS_SUCCEEDED(appDir->GetPath(path)));
> +        aCmdLine.AppendLooseValue(UTF8ToWide("-appdir"));
> +        std::wstring wpath = path.get();
> +        aCmdLine.AppendLooseValue(wpath);
> +        wprintf(L"converted: %s\n", wpath.c_str());

nit - remove the debug printf

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f060b308ec40

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f060b308ec40

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5545627073b9

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5545627073b9

Comment 9

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 43.0a1 (Build ID: 20150825030212) on windows 8.1 64-bit with the instructions from comment 0 .

Verified as fixed with Firefox Aurora 45.0a2 (Build ID: 20160116004013)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0