1198452 - Save the deployed revision SHA to somewhere outside of the media directory

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect, P2)

Description

[Ed Morley [:emorley]]

We currently store the deployed revision in:
<repo-root>/treeherder/webapp/media

Which gets served as:
treeherder.{mozilla,allizom}.org/media/revision

However in bug 1197799 we're switching from serving assets with Apache, to using gunicorn/Whitenoise, and Whitenoise does not support serving files from /media/.

Given `revision` isn't anything to do with Django, I'd say let's move it out of /media/ and into the site root, by placing it in the dist/ directory.

We'll need to update the What's Deployed link, and the IRC pushbots config in puppet, but I think the new URL of treeherder.{mozilla,allizom}.org/revision makes more sense anyway.

Comment 1

[Ed Morley [:emorley]]

Attachment: Save the deployed revision to <site-root>/revision.txt

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8652541 [details] [review]
Save the deployed revision to <site-root>/revision.txt

Now that's a low-risk fix.  :)

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/90576b9fd9a0b7727072151c00042ea47c719161
Bug 1198452 - Save the deployed revision to <site-root>/revision.txt

Since WhiteNoise won't serve files from /media/, so the existing file
in `treeherder/webapp/media/` 404s when accessed via:
https://treeherder.{mozilla,allizom}.org/media/revision

IMO the site root makes more sense for this file anyway, so let's just
save it under `dist/`. Also adds a .txt extension for clarity.

The old file has been left for now to ease the transition, and will be
deleted once the IRC pushbots config and What's Deployed URLs have been
updated.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d061270a8c6a703f4de10c1a2679d5ee9cf85493
Bug 1198452 - Update the "What's Deployed" URL for new revision location

The revision files are now located at:
https://treeherder.allizom.org/revision.txt
https://treeherder.mozilla.org/revision.txt

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/abbaa1918d99eb092b0de25cda49a1d447f3eb1e
Bug 1198452 - Stop creating treeherder.*.org/media/revision

Now that the IRC pushbot configs/What's Deployed links have been updated
to use the new revision.txt file location, we can stop creating the file
in the old location.

Comment 6

[Ed Morley [:emorley]]

I've also removed the old `treeherder/webapp/media/revision` file on the admin node's stage/prod directories (since post bug 1124382 they won't be covered by the .gitignore, and so will show as untracked changes).