1198536 - Remove job.build_url since it's unused

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Cameron Dawson [:camd]]

The ``build_url`` field appears to be vestigial.  We should remove references to it.

Comment 1

[Jonathan French (:jfrench)]

Tapesh expressed interest in fixing this one. Camd I'll let you make the call on its suitability for contribution (if it's easy or complex w.r.t. the change and testing/validation).

Tapesh, just a heads up there hasn't been a decision on good-first-bug strategy going forward into Q4 (I tried to reply to you before you left IRC) so if this bug is assigned we'll just assign it to you likely without that whiteboard/keyword value.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So how are different jobs like N, Mn, and others are setting the build url? It's clearly present for all of them with a URL to ftp.mozilla.org.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Latest conversation from IRC to be continued here:

<camd> whimboo: it looks like it derives that from the job_log_url
<camd> it slices off the last element to get it
<camd> https://github.com/mozilla/treeherder/blob/master/ui/js/models/job_log_url.js#L41-41
<camd> whimboo|afk: whew, trickery!  yeah, it takes the url for the raw log and hacks off the log name
<whimboo> camd: so "build" in terms of its name is not related to the Firefox build which gets tested but the task which is performed for this specific job
<whimboo> its a bit misleading

Maybe we can make it similar to my proposal on bug 1207810? At least for us the log location is not the actual build location. As of now I have to push a separate "CI Build" artifact in the report:

https://treeherder.mozilla.org/logviewer.html#?job_id=2273911&repo=mozilla-central

Comment 4

[Ed Morley [:emorley]]

"build_url" really means "binary_url" - and was added in case it would be useful for tooling (eg bisect-in-the-cloud).

However we neither populate it nor use it at the moment, so should probably just remove it.

Re the "go to build directory" link, that's unrelated, and is generated by chopping off the log filename from log_url. Implementing something better for that is bug 1060649 (plus see list of related bugs in bug 1160410 comment 5).

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I see but why not using the existent and not used build_url property for bug 1060649? So I did another check and for most CI systems they call every job as run also a build. So build_url might not always refer to a binary_url but the build in the CI tool.

Comment 6

[Ed Morley [:emorley]]

Because (a) it's really build_directory_url, (b) with the move from FTP to S3 we may need to completely rethink this anyway (there may not be a directory)

Comment 7

[Cameron Dawson [:camd]]

I must defer to Ed's wisdom on this one.  He's looked into it much more than I have.

Comment 8

[Ed Morley [:emorley]]

I have a branch for this locally.

Comment 9

[Ed Morley [:emorley]]

Attachment: Remove job.build_url since it's unused

Comment 10

[Cameron Dawson [:camd]]

Comment on attachment 8669449 [details] [review]
Remove job.build_url since it's unused

Saw one sample file that still has the reference.  Made comment.  Other than that, please feel free to merge.  Thanks for cleaning up all this cruft!  :)

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/364f635917ec9d13166443f1ee0a07993a97b62d
Bug 1198536 - Remove job.build_url since it's unused