Closed Bug 1198547 Opened 5 years ago Closed 5 years ago

Update sidebar background color for Win10

Categories

(Firefox :: Theme, defect, P3)

Unspecified
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 43
Tracking Status
firefox41 --- verified
firefox42 --- verified
firefox43 --- verified

People

(Reporter: Dolske, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [testday-20150901])

Attachments

(1 file)

The bookmark/history sidebar background color has a light blueish tint. This color seems out of place to me on Windows 10. Seems like it should either be white or the same color as the navbar?
Flags: needinfo?(shorlander)
Blocks: theme-win10
Yes, the blue was specifically picked for Vista. Should be an easy fix.
Assignee: nobody → dao
Blocks: 1192839
OS: Unspecified → Windows 10
Priority: -- → P3
Summary: Update sidebar background color for Win10? → Update sidebar background color for Win10
Attached patch patchSplinter Review
Attachment #8652872 - Flags: review?(dolske)
Attachment #8652872 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/f18647d60529
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Flags: needinfo?(shorlander) → qe-verify+
Comment on attachment 8652872 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Windows 10 release
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: very simple styling change, low risk
[String/UUID change made/needed]:
Attachment #8652872 - Flags: approval-mozilla-beta?
Attachment #8652872 - Flags: approval-mozilla-aurora?
Comment on attachment 8652872 [details] [diff] [review]
patch

Seems like a safe change to uplift to Aurora and Beta. It would be much harder to uplift such changes, a week from now when Beta41 cycle enters it's end game.
Attachment #8652872 - Flags: approval-mozilla-beta?
Attachment #8652872 - Flags: approval-mozilla-beta+
Attachment #8652872 - Flags: approval-mozilla-aurora?
Attachment #8652872 - Flags: approval-mozilla-aurora+
Verified as fixed on Windows 10 64bit with Firefox 41.0b6 (20150831172306) while still bluish on Firefox 40.0.3 (20150826023504).
Status: RESOLVED → VERIFIED
Whiteboard: [testday-20150901]
I was able to reproduce this issue on Firefox 43.0a1 (2015-08-25) under Windows 10 32-bit. 
Verified fixed on Firefox 43.0a1 (2015-09-01), Firefox 42.0a2 (2015-09-01) and Firefox 41 Beta 6 (20150831172306) under Windows 10 32-bit.

And also many thanks Jerod Lycett for your testing!
You need to log in before you can comment on or make changes to this bug.