1198657 - Remove unnecessary minimized statusbar width update

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Ting-Yu Chou [:ting] (away)]

I can see two _updateMinimizedStatusbarWidth() invocations when launch an app, one from handling |hierarchytopmostwindowchanged| and one from handling |appopened|.

The first invocation gets different numbers of _minimizedStatusbarWidth in each launch which probably becasue the openning window is enlarging, and the 2nd one will get usual number (~ half screen width).

The first one is unnecessary, we can avoid it (and getBoundingClientRect()).

Also maybe we can skip _updateIconVisibility() in _updateMinimizedStatusbarWidth() if the width is not changed.

Comment 1

[Alberto Pastor [:albertopq]]

True (and looking forward to get rid of it!), but I wouldn't spend much time on this. All the minimized/maximized logic is going to go away on bug 1179723. It would be nice if you can give a try to that patch and provide some performance feedback! :)

Comment 2

[Ting-Yu Chou [:ting] (away)]

Great! Thanks for the info, I'll try the patch.

Note for my self: _updateIconVisibility() is done twice when handle |appopened|, one from resumeUpdate(), one from _updateMinimizedStatusbarWidth().

Comment 3

[Ting-Yu Chou [:ting] (away)]

Oops, I didn't see patch in bug 1179723?

Comment 4

[Ting-Yu Chou [:ting] (away)]

No longer valid as bug 1179723 is just landed.