1198723 - Search suggestions prompt appears even if the option is already selected in about:preferences#search

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P4)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Reproduced with Dev Edition 42.0a2 and Nightly 43.0a1 2015-08-25 under Ubuntu 14.04 x86, Mac OS X 10.9.5 and Win 10 x64.

Steps to reproduce:
1. Open Firefox with a clean profile 
 -- Set browser.urlbar.unifiedcomplete to true in Dev Edition
2. Go to about:preferences#search and tick the check box "Show search suggestions in location bar results"
3. Start typing in the url bar

Actual results:
The search suggestions prompt is displayed.

Expected results:
The prompt shouldn't be shown anymore; the user already made this choice.

Note: Also, if the user selects Yes to see the search suggestions, and then modifies browser.urlbar.userMadeSearchSuggestionsChoice to false, the checkbox remains ticked.

Comment 1

[Marco Bonardo [:mak]]

not critical, the case of user setting the pref before entering anything in the urlbar should be rare enough.

Comment 2

[Drew Willcoxon :adw]

Attachment: patch

This makes the _userMadeSearchSuggestionsChoice field equal to userMadeSearchSuggestionsChoice || suggest.searches.  It still sets userMadeSearchSuggestionsChoice=true when you opt in or out, but now it can also be the case that !userMadeSearchSuggestionsChoice but suggest.searches implies that you made a choice.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=56b54161038e

Comment 3

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/44fc4c98e5fe

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44fc4c98e5fe

Comment 5

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Dev Edition 43.0a2 2015-09-23, Win 7 and Mac OS X 10.9.5.