1198757 - trigger suggester needs templated urls

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In bug #1175123, we wrote a trigger suggester that will show suggestions if the feedback response meets certain criteria.

This can be used to suggest surveys for soliciting additional information about problems we're having difficulties with reproducing or sussing out.

Gregg pointed out that it helps a lot if we can pass along things like the product, version and locale in the survey link url. This requires that we support templated urls where a url can be something like this:

    https://somesurvey/?product={PRODUCT}&locale={LOCALE}&version={VERSION}

and the suggester will fill in the values from the feedback response.

Requirements:

* support PRODUCT, LOCALE, VERSION
* if there is no value available, send an empty string
* the help text for the trigger rule form should mention which variables are supported

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think this about a day of work or so. Tentatively assigning it 2 points.

Grabbing it to work on today or tomorrow.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this block on bug #1198766 because that one has code changes this one will need landed first.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I have this mostly implemented, but it relies on bug #1198766 to land first. I added support for PRODUCT, VERSION, PLATFORM, LOCALE and HAPPY figuring those are all interesting.

Once bug #1198766 lands, I'll make a PR for this.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/661

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was a 2 point bug. Not sure why I had it as u=2.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master: https://github.com/mozilla/fjord/commit/433b7db36d17d049875249c08c04d54d323a7540

Pushed to stage. Created a "rehan" trigger that passes sentiment in the url. Works super. Pushed to prod.

Marking as FIXED!