1198831 - JavaScript error: chrome://browser/content/tabbrowser.xml, line 4207: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebProgress.removeProgressListener]

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Benoit Girard (:BenWa)]

I hit a leak when trying to land bug 1186662.

This can be reproduced using:
./mach mochitest --e10s browser/base/content/test/general/browser_tab_drag_drop_perwindow.js

You get:
JavaScript error: chrome://browser/content/tabbrowser.xml, line 4207: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebProgress.removeProgressListener]

This was coding my code afterwards to not run. For now I'm working around this by having my code run after this is thrown but we need to fix this properly.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1198831-Fix-browser_tab_drag_drop_perwindow.js-l.patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8655483 [details] [diff] [review]
0001-Bug-1198831-Fix-browser_tab_drag_drop_perwindow.js-l.patch

Review of attachment 8655483 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/tabbrowser.xml
@@ +2472,5 @@
>  
> +            let ourBrowser = this.getBrowserForTab(aOurTab);
> +            let otherBrowser = aOtherTab.linkedBrowser;
> +
> +            // Can only swap docshells between browsers in the same process.

How does this work when `dom.ipc.processCount` is greater than 1? The tabs won't necessarily be in the same process.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> > +            // Can only swap docshells between browsers in the same process.
> 
> How does this work when `dom.ipc.processCount` is greater than 1? The tabs
> won't necessarily be in the same process.

Hmm, that comment is misleading, I see. We can't swap frameLoaders when one is in the UI process and one is in a content process. With bug 918634 fixed we should be able to swap between two different content processes though.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8655483 [details] [diff] [review]
0001-Bug-1198831-Fix-browser_tab_drag_drop_perwindow.js-l.patch

Review of attachment 8655483 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/tabbrowser.xml
@@ +2472,5 @@
>  
> +            let ourBrowser = this.getBrowserForTab(aOurTab);
> +            let otherBrowser = aOtherTab.linkedBrowser;
> +
> +            // Can only swap docshells between browsers in the same process.

r+ with this comment changed to:
// Can't swap between chrome and content processes.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> r+ with this comment changed to:
> // Can't swap between chrome and content processes.

Will do, thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/995d539b9a2d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/995d539b9a2d