[CompatData][Importer] Handle {{CompatChromeMobile("42")}} Kumascript

RESOLVED FIXED

Status

developer.mozilla.org
General
--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwhitlock, Assigned: jwhitlock)

Tracking

Details

(Whiteboard: [specification][type:bug], URL)

(Assignee)

Description

3 years ago
What did you do?
================
With the new importer from bug 1171957:
1. Go to https://browsercompat.herokuapp.com/importer/1923 (importer page for https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand)
2. Press "Reset" button


What happened?
==============
Got error "Unknown KumaScript {{CompatChromeMobile("42")}} in compatibility support."

What should have happened?
==========================
The round 2 importer converted this to version 42.0

Is there anything else we should know?
======================================
Used 1 time on this page
(Assignee)

Updated

3 years ago
Blocks: 1181140
Severity: normal → critical
Depends on: 1171957

Comment 1

3 years ago
John,

Joe Medley here from Google. 

Until today, I wasn't aware of text on MDN called Chrome Mobile and would have vetoed the name had it been presented to me since the name is meaningless.

Chrome on Android and Chrome on iOS use different rendering engines. To make a long story short, there is no reliable feature parity between the two. 

I've replaced {{CompatChromeMobile(42)}} with {{CompatChrome(42)}} in the page linked above. 

Incidentally, I've previously proposed equivalent macros for Android Chrome and Android Webview and have agreed to hold off on such enhancements while the compatibility API is being worked on.
(Assignee)

Comment 2

3 years ago
Since this was the only page using this macro, and the macro is invalid anyway, I'll close this bug as "Won't Fix", once we resolve this "Chrome Mobile" issue.

In the API, we've got "Chrome", "Chrome for Android", "Chrome Mobile", and "Android Webview".  It sounds like "Chrome Mobile" should be deleted:

https://browsercompat.herokuapp.com/browse/browsers/5
https://browsercompat.herokuapp.com/browse/versions/66

If I do this, using "Chrome Mobile" will add an 'unknown_browser' issue, prompting to fix the source page.

So, do you endorse removing "Chrome Mobile" and the related version?
Assignee: nobody → jwhitlock
Status: NEW → ASSIGNED
Flags: needinfo?(jmedley)

Comment 3

3 years ago
I support it, but why don't we clean up the offending pages first. Is there a way to generate a list of all the pages that have it? My team needs to review them and make sure the right version gets put in.
Flags: needinfo?(jmedley)
(Assignee)

Comment 5

3 years ago
That covers fixing pages that use {{CompatChromeMobile}}.  Deleting the API resources will allow us to detect the name in compatibility table columns.  It will add an 'unknown_browser' issue, available after a scrape [1]


We could use a a comment on {{CompatChromeMobile}} [2] that {{CompatChrome}} [3] should be used instead.  needinfo-ing sheppy, who wrote both of them.  

[1] https://browsercompat.herokuapp.com/importer/issues/unknown_browser
[2] https://developer.mozilla.org/en-US/docs/Template:CompatChromeMobile
[3] https://developer.mozilla.org/en-US/docs/Template:CompatChrome
Flags: needinfo?(eshepherd)
Yeah, these were added back when Google first announced Chrome for Android and we needed to differentiate it from the original Android browser, and there were naming issues which complicated the process a bit.

Is the mobile version of Chrome always 100% feature-compatible with the like-versioned desktop version? If so, that's great. But if there are differences, then we need to have a separate macro for the mobile releases.

Are mobile and desktop Chrome always aligned in every way from a dev standpoint?
Flags: needinfo?(eshepherd) → needinfo?(jwhitlock)
Oh brother, I didn't realize they're identical macros. Never mind all of comment #6. Pretend I never posted that.

I've added the comment. Do we want to go a step further and, since it's not used anywhere, really, delete the macro outright?
(Assignee)

Comment 8

3 years ago
sheppy:

Delete it if you want to.  My understanding is that macros were never delete, since you had to render old revisions of pages that used the macro.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(jwhitlock)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.