1198891 - Tab/Window Sharing icon should turn blue when sharing is active

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Sevaan Franks [:sevaan]]

Attachment: Active Icons

When a user turns on tab or window sharing, the sharing icon should turn blue to indicate that sharing is active (the same way the camera/microphone icons are blue when active).

http://i.sevaan.com/image/3200102d0p1l

Comment 1

[Ed Lee :Mardak]

(In reply to Sevaan Franks [:sevaan] from comment #0)
> Created attachment 8652999 [details]
> Active Icons
> http://i.sevaan.com/image/3200102d0p1l
Your attachment is the same as the linked image. Did you mean to attach icons?

Comment 2

[Ed Lee :Mardak]

(In reply to Sevaan Franks [:sevaan] from comment #0)
> the same way the camera/microphone icons are blue when active
Actually, those icons are always blue. They have a slash through them when disabled.

Should it be default to sharing-mute when not active? .. which seems to already exist:

http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/content/shared/img/svg/sharing-mute.svg

Comment 3

[Mark Banner (:standard8)]

(In reply to Ed Lee :Mardak from comment #2)
> (In reply to Sevaan Franks [:sevaan] from comment #0)
> > the same way the camera/microphone icons are blue when active
> Actually, those icons are always blue. They have a slash through them when
> disabled.
> 
> Should it be default to sharing-mute when not active? .. which seems to
> already exist:
> 
> http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/
> content/shared/img/svg/sharing-mute.svg

Hmm, I thought that was what the button should be to click on to stop sharing - that's what https://www.dropbox.com/s/4gdkx44rnpjrtbw/CommonEements_Sheet.png?dl=0 says.

So currently the implementation is wrong according to the element sheet (we display it with the slash through when disabled, and display the normal icon in the 2nd state).

Sevaan: Can you clarify what you want - do you want what's on the element sheet, or the element sheet plus a change to blue?

Comment 4

[Sevaan Franks [:sevaan]]

Attachment: Icon States

I don't think it should default to the sharing icon with the slash through it, which implies that sharing is on, but just temporarily disabled.

I just think the icon should be blue when sharing is on. Then it can stay dark when sharing is off. Otherwise users don't have any indication that it is turned on.

Also, I noticed just now that when activating tab sharing, the icon switches to the mute state for a second before returning to normal.

Comment 5

[Mark Banner (:standard8)]

Attachment: Make the tab sharing icon turn blue when sharing is active

Comment 6

[Mark Banner (:standard8)]

Attachment: Screen shot with patch applied

This implements as Sevaan suggested. The views:

- Left: screen sharing not active (unchanged)
- Middle: screen sharing button disabled, this happens whilst the prompt for the window to select is active.
- Right: screen sharing active.

Comment 7

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8657769 [details]
Screen shot with patch applied

Thanks!

Comment 8

[Ed Lee :Mardak]

Comment on attachment 8657768 [details] [diff] [review]
Make the tab sharing icon turn blue when sharing is active

Review of attachment 8657768 [details] [diff] [review]:
-----------------------------------------------------------------

r=Mardak

::: browser/components/loop/content/shared/css/conversation.css
@@ +230,4 @@
>  }
>  
>  .btn-screen-share.disabled {
> +  background-image: url("../img/svg/sharing-disabled.svg");

We can rename the file to -pending instead of -disabled

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/982e7fa091fa

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/982e7fa091fa

Comment 11

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using old Nightly from 2015-09-08, verified that the issue is fixed using latest Developer Edition 43.0a2 across platforms (Windows 7 64-bit, Windows 10 64-bit, Mac OS X 10.11 and Ubuntu 14.04 32-bit).