1198901 - [Gallery] User is able to save image when setting wallpaper. Image does not save.

Status: RESOLVED DUPLICATE of bug 1198522

(Firefox OS Graveyard :: Gaia::Gallery, defect, P2)

Description

[John Thomas [:Johnt]]

Attachment: logcat_20150826_1155.txt

Description:
After selecting an image from gallery and choosing the set as wallpaper option the user is able to press and hold the image in order to save the image. After selecting to save the image the image is not saved.


Repro Steps:

Prereq: At least 1 image within gallery.

1) Update a Aries to 20150826130914
2) Select Gallery
3) Select Image
4) Select Share button
5) Select Wallpaper button
6) Press and hold image
7) Select Save
8) Restart Gallery
9 Open Gallery

Actual:
Pressing and holding image while setting as wallpaper displays a list of options. Selecting Save has no function.

Expected:
It is expected that pressing and holding the image while setting as wallpaper will not display a list of options, OR that the save option will not be available.

Environmental Variables:
Device: Aries 2.5 Kk
BuildID: 20150826130914
Gaia: c1ae9f02f2a9cfb89bf67aeea97e467c41c3362c
Gecko: a031de3162e46c9d6eeed580045c4f2bb61ffd05
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro frequency: 4/4
See attached: Logcat & Video
Video link: https://youtu.be/rMPXcpY0pJM

Comment 1

[John Thomas [:Johnt]]

This issue DOES occur on Flame 2.5
Result: List of Options are displayed when pressing and holding on a image when setting as Wallpaper. "Copy Image, Save Image and Share Image". Save Image has no function.

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (319mb)
Build ID: 20150825210535
Gaia: c1ae9f02f2a9cfb89bf67aeea97e467c41c3362c
Gecko: f61c3cc0eb8b7533818e7379ccc063b611015d9d
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

=----------------------------------=

This does NOT occur on Flame 2.2.
Result: No additional options appear when pressing and holding image while setting as Wallpaper.

Environmental Variables:
Device: Flame 2.2 Kk Fullflash (319mb)
BuildID: 20150821074640
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: d29ec25e40e7
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

This might be a dupe of bug 1198522. The difference is the share through email and messaging options are working here.

Comment 3

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:
Functional regression

Comment 4

[Mahendra Potharaju [:mahe]]

Can you please confirm if this still occurs? Wasn't able to reproduce it

Comment 5

[Pi Wei Cheng [:piwei] (inactive)]

This still occurs on latest Aries and Flame. I'm guessing when long-pressing on set wallpaper screen there should NOT be any option appearing and that's what 2.2 does - nothing happens when long pressing on that screen.

Device: Flame 2.5
BuildID: 20150918030223
Gaia: 4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko: 11dc79e232110ba6de5179e46dfbda77b52a88c3
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Aries 2.5
BuildID: 20150918122511
Gaia: 4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko: 37c7812ce0e6d10c7e7182f12e752832835e1d67
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 6

[Hema Koka [:hema]]

Punam,

Assigning this to you. Please investigate this next week when you are back at work.

Thanks
Hema

Comment 7

[Punam Dahiya [:pdahiya]]

Investigated the issue and context menu shown on long press is coming from System app and is not a change in wallpaper app.
This issue looks similar to Bug 1198522, Setting NI flag for Boris to provide his input on long press issue seen in wallpaper app. Thanks!

Comment 8

[Boris Chiou [:boris]]

(In reply to Punam Dahiya from comment #7)
> Investigated the issue and context menu shown on long press is coming from
> System app and is not a change in wallpaper app.
> This issue looks similar to Bug 1198522, Setting NI flag for Boris to
> provide his input on long press issue seen in wallpaper app. Thanks!

Thanks for your ni. I would check this bug to make sure if it is related to Bug 1198522.

Thanks.

Comment 9

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #8)
> (In reply to Punam Dahiya from comment #7)
> > Investigated the issue and context menu shown on long press is coming from
> > System app and is not a change in wallpaper app.
> > This issue looks similar to Bug 1198522, Setting NI flag for Boris to
> > provide his input on long press issue seen in wallpaper app. Thanks!
> 
> Thanks for your ni. I would check this bug to make sure if it is related to
> Bug 1198522.
> 
> Thanks.

After some tests, I believe Bug 11198522 also fixed this bug. Punam, could you please check this bug again after pulling your gecko and gaia to the master branch tip? Thanks

Comment 10

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #8)
> (In reply to Punam Dahiya from comment #7)
> > Investigated the issue and context menu shown on long press is coming from
> > System app and is not a change in wallpaper app.
> > This issue looks similar to Bug 1198522, Setting NI flag for Boris to
> > provide his input on long press issue seen in wallpaper app. Thanks!
> 
> Thanks for your ni. I would check this bug to make sure if it is related to
> Bug 1198522.
> 
> Thanks.

After testing on my aries, I believe Bug 1198522 also fixed this bug. Punam, could you please check this bug again after pulling your gecko and gaia to the master branch tip? Thanks.

Comment 11

[Punam Dahiya [:pdahiya]]

I am able to replicate this issue on Flame-kk 2.5 buildId: 20150924030228

This is the latest build available on http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central-flame-kk-eng/

This build might not have fix from bug 1198522. Leaving NI flag to test with next released build and updated bug with my findings.

Comment 12

[Boris Chiou [:boris]]

(In reply to Punam Dahiya from comment #11)
> I am able to replicate this issue on Flame-kk 2.5 buildId: 20150924030228
> 
> This is the latest build available on
> http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central-
> flame-kk-eng/
> 
> This build might not have fix from bug 1198522. Leaving NI flag to test with
> next released build and updated bug with my findings.

Thank you. I pulled my B2G flame kk repository today and then built it (full build). I cannot reproduce it now. Maybe we just bumped B2G to the newest version last night. Please keep testing with next release build. Thank you very much.

Comment 13

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #12)
> (In reply to Punam Dahiya from comment #11)
> > I am able to replicate this issue on Flame-kk 2.5 buildId: 20150924030228
> > 
> > This is the latest build available on
> > http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central-
> > flame-kk-eng/
> > 
> > This build might not have fix from bug 1198522. Leaving NI flag to test with
> > next released build and updated bug with my findings.
> 
> Thank you. I pulled my B2G flame kk repository today and then built it (full
> build). I cannot reproduce it now. Maybe we just bumped B2G to the newest
> version last night. Please keep testing with next release build. Thank you
> very much.

In the new version, we shouldn't see the 'save', 'copy', 'share' image options. In other words, there is not context menu after you long press this image in the gallery app.

Comment 14

[Punam Dahiya [:pdahiya]]

Thanks Boris. The issue is fixed for Flame-kk on build Id: 20150925030204. Marking bug as resolved duplicate of Bug 1198522.