1199057 - IonMonkey: MIPS32: Plumb new.target on the stack and make it accessible to JSNatives

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

python2 ./jit_test.py -f --tbpl /tmp/js.32 basic/newTargetRectifier.js
Exit code: -10
FAIL - basic/newTargetRectifier.js
[0|1|0|0]  16% ========>                                              |   0.6s
Exit code: -10
FAIL - basic/newTargetRectifier.js
[0|2|0|0]  33% =================>                                     |   0.6s
Exit code: -10
FAIL - basic/newTargetRectifier.js
[1|3|0|0]  66% ===================================>                   |   1.2s
Exit code: -10
FAIL - basic/newTargetRectifier.js
[1|4|0|0]  83% ============================================>          |   1.2s
Exit code: -10
FAIL - basic/newTargetRectifier.js
[1|5|0|0] 100% ======================================================>|   1.4s

Comment 1

[hev [:hev]]

Attachment: 0001-IonMonkey-MIPS32-Plumb-new.target-on-the-stack-and-m.patch

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8653224 [details] [diff] [review]
0001-IonMonkey-MIPS32-Plumb-new.target-on-the-stack-and-m.patch

Review of attachment 8653224 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips32/Trampoline-mips32.cpp
@@ +162,4 @@
>      Loop over argv vector, push arguments onto stack in reverse order
>      ***************************************************************/
>  
> +    // if we are constructing, that also needs to include newTarget

nit: what is "that"?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8289ad7fa005

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8289ad7fa005