Refactor FxOS Geo Stumbling (follow-up work of Bug 1154435)

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
3 years ago
6 months ago

People

(Reporter: alchen, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
This is follow-up bug for FxOS Geo Stumbling.
In this bug, we would like to complete the following items.
1. Refactoring to a high layer. (a function such as nsGeolocationService::geostumble(nsGeoPosition))
2. Upload Stumble as gzip format
3. Creating an XPCOM component to replace most of UploadStumbleRunnable::Run
(Reporter)

Updated

3 years ago
Depends on: 1154435

Updated

3 years ago
Blocks: 1199395

Comment 1

3 years ago
> 2. Upload Stumble as gzip format

I created bug 1199395 for this item

Comment 2

3 years ago
> 3. Creating an XPCOM component to replace most of UploadStumbleRunnable::Run

Josh made the valid point that XHR in JS is cleaner/simpler code. 
When you add js + idl file + manifest file + mozbuild changes, I think the handful of lines of cpp code to do this becomes about the same number of lines in this approach. I am not sure this is needed because this is such a small piece.
(Reporter)

Comment 3

3 years ago
(In reply to Garvan from comment #2)
> > 3. Creating an XPCOM component to replace most of UploadStumbleRunnable::Run
> 
> Josh made the valid point that XHR in JS is cleaner/simpler code. 
> When you add js + idl file + manifest file + mozbuild changes, I think the
> handful of lines of cpp code to do this becomes about the same number of
> lines in this approach. I am not sure this is needed because this is such a
> small piece.

Agree.
Josh, what do you think?
Flags: needinfo?(josh)
Yeah, I think there are better ways we can use our time than doing the JS rewrite.
Flags: needinfo?(josh)
I don't think we are going to work on this anymore. Closing.
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.