1199139 - Not clicking exactly at the right place to see details about a test folds test results

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Mike Hommey [:glandium]]

This has happened to me enough today that I feel this needs to be addressed somehow: I was trying to look at talos results on try, and many times I would not click exactly on the talos test name text, and that would result in the whole thing folding instead of displaying the test details which is what my intent was.

Comment 1

[Jonathan French (:jfrench)]

Does using left/right or n,p,j,k keys for navigation address selection when trying to rapidly select the first job in a T( ) group.. if that is your workflow to reproduce?

That's the only target area I am aware of, (clicking somewhere in front of the first " (" paren in the group) that should collapse the counts back to +n.

If it's not and we are collapsing when clicking somewhere inside ( ), that's definitely a bug.

Comment 2

[Phil Ringnalda (:philor)]

About half the width of the last character in a symbol is a target: uncollapse something, then start your mouse at the ( and slowly move it across looking at whether the symbol has the selection background. It goes away, and thus you'll collapse on click, long before you would think your mouse was off the symbol.

Comment 3

[Jonathan French (:jfrench)]

Awesome, thank you Phil! Yeah I can repro now.

Comment 4

[Jonathan French (:jfrench)]

I think I know what this is now, so assigning.

Comment 5

[Jonathan French (:jfrench)]

Attachment: PR 930

PR for review.

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8655015 [details] [review]
PR 930

Still a couple things to clean up here.  Going with an r- to clear my conscience (and review queue) till you make your changes.  :)

Comment 7

[Jonathan French (:jfrench)]

Trying to manipulate the many dependent job row/group/list elements with inverted margin values (to remove the empty space between jobs that was allowing the selection) and match precisely what we already have has been pretty painful so far, so let's make this PR just about clickGroupCb() for now to block the expand/collapse, and I'll open a follow up for removing the empty space between jobs. That way at least part of the fix gets to the users.

Comment 8

[Jonathan French (:jfrench)]

Comment on attachment 8655015 [details] [review]
PR 930

PR for re-review.

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5e99628b1b57cc6bbff133e43af25329d9b2e4d5
Bug 1199139 - Prevent accidental job count group collapse

Comment 10

[Jonathan French (:jfrench)]

Marking fixed per above merge.

Comment 11

[Jonathan French (:jfrench)]

Verified fixed on production.