Closed Bug 1199163 Opened 9 years ago Closed 9 years ago

Port the long press key tests from Gip to Gij

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

Apparently Gip is no longer running on TC so something caused the regression in bug 1197739. Need to add that test to Gij ...
Comment on attachment 8653941 [details] [review]
[gaia] timdream:keyboard-longpress-test > mozilla-b2g:master

Evan I think you are capable of reviewing this. Could you help? Thanks.
Attachment #8653941 - Flags: review?(evan)
It looks like the test would not be able to caught the regression like bug 1197739 anyway because of the different code path? Anyway, we should check this in regardless...
Comment on attachment 8653941 [details] [review]
[gaia] timdream:keyboard-longpress-test > mozilla-b2g:master

Tim, 

Sure, I can help.

LGTM.
Attachment #8653941 - Flags: review?(evan) → review+
master: https://github.com/mozilla-b2g/gaia/commit/0e3ce06c7dce2061b91bcda011bd8a471f0b197d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: