Closed
Bug 1199163
Opened 9 years ago
Closed 9 years ago
Port the long press key tests from Gip to Gij
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timdream, Assigned: timdream)
References
Details
Attachments
(1 file)
Apparently Gip is no longer running on TC so something caused the regression in bug 1197739. Need to add that test to Gij ...
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8653941 [details] [review] [gaia] timdream:keyboard-longpress-test > mozilla-b2g:master Evan I think you are capable of reviewing this. Could you help? Thanks.
Attachment #8653941 -
Flags: review?(evan)
Assignee | ||
Comment 3•9 years ago
|
||
It looks like the test would not be able to caught the regression like bug 1197739 anyway because of the different code path? Anyway, we should check this in regardless...
Comment 4•9 years ago
|
||
Comment on attachment 8653941 [details] [review] [gaia] timdream:keyboard-longpress-test > mozilla-b2g:master Tim, Sure, I can help. LGTM.
Attachment #8653941 -
Flags: review?(evan) → review+
Assignee | ||
Comment 5•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/0e3ce06c7dce2061b91bcda011bd8a471f0b197d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•