Closed
Bug 1199182
Opened 10 years ago
Closed 10 years ago
[New-Homescreen] Sometimes page isn't long enough or divides in incorrect places
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Occasionally (often on startup, sometimes after changing column layout), the page size and division are incorrect. This can leave some icons inaccessible or permanently cut-off.
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [systemsfe]
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
|
||
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master
I'm not able to reproduce after this patch, but this can be tricky to reproduce... I think this is the right fix though, and if not, we can reopen/file a new bug.
Attachment #8656072 -
Flags: review?(apastor)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master
The code looks good to me, but I'm not too familiar with the Homescreen code. Let's ask somebody that worked in the old one for a second eye. Thanks!
Attachment #8656072 -
Flags: review?(kevingrandon)
Attachment #8656072 -
Flags: review?(apastor)
Attachment #8656072 -
Flags: feedback+
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master
I don't know this code too well either, but seems fine to me. Left a comment on github which you can choose to address if you want to.
Attachment #8656072 -
Flags: review?(kevingrandon) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master
I made the suggested change, but it required enough restructuring of unit tests that I think it's worth another quick look.
Attachment #8656072 -
Flags: review+ → review?(kevingrandon)
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master
I didn't test this, but it seems fine to me. Thanks!
Attachment #8656072 -
Flags: review?(kevingrandon) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•