1199182 - [New-Homescreen] Sometimes page isn't long enough or divides in incorrect places

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

Occasionally (often on startup, sometimes after changing column layout), the page size and division are incorrect. This can leave some icons inaccessible or permanently cut-off.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master

I'm not able to reproduce after this patch, but this can be tricky to reproduce... I think this is the right fix though, and if not, we can reopen/file a new bug.

Comment 3

[Alberto Pastor [:albertopq]]

Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master

The code looks good to me, but I'm not too familiar with the Homescreen code. Let's ask somebody that worked in the old one for a second eye. Thanks!

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master

I don't know this code too well either, but seems fine to me. Left a comment on github which you can choose to address if you want to.

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master

I made the suggested change, but it required enough restructuring of unit tests that I think it's worth another quick look.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8656072 [details] [review]
[gaia] Cwiiis:bug1199182-new-homescreen-height-set > mozilla-b2g:master

I didn't test this, but it seems fine to me. Thanks!

Comment 7

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/b04acdefbce6ad51451abe5f5eaab3dc2a9ee35f