Closed
Bug 1199205
Opened 9 years ago
Closed 7 years ago
Allow to run some inspector tests on luciddream
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(3 files, 2 obsolete files)
5.59 KB,
patch
|
Details | Diff | Splinter Review | |
10.04 KB,
patch
|
Details | Diff | Splinter Review | |
4.48 KB,
patch
|
Details | Diff | Splinter Review |
Now that bug 1137285 landed, inspector tests can theoretically run on luciddream via the test actor. But various still fails. Steps are: - tweak luciddream test harness to be able to run inspector tests - tweak inspector test head.js/test actor to be able to run on luciddream - enable the already passing tests - tweak tests or inspector code to get more running (Note that we won't enable all of them, as some are really specific to testing Firefox Desktop features, like "context menu->inspect" test)
Assignee | ||
Comment 1•9 years ago
|
||
WIP patch. Depends on the various patches I submitted in blocker bugs. This tweaks some tests, add luciddream.ini tests and hook head.js helpers to call luciddream ones (that, to open webide toolbox instead of browser toolbox).
Assignee | ||
Comment 2•9 years ago
|
||
Here is various small tweaks I had to do over inspector tests in order to run flawlessly on luciddream. - waiting for additional events to prevent races/pending request exceptions - use TEST_URL_ROOT, always, as file maps to different kind of URLs on luciddream - pass the window on synthesizeKey prevents easily document focus issues! - workaround the fact that the webconsole is already opened on luciddream, the webconsole-ready event is only fired on the very first time the console is opened (may be we should introduce a new event, fired any time the console is opened) - help distinguishing data: documents being used between tests (useful when something bad happens) https://treeherder.mozilla.org/#/jobs?repo=try&revision=659a122a3186
Attachment #8665427 -
Attachment is obsolete: true
Assignee | ||
Comment 3•9 years ago
|
||
Once deps are ready, we can land that patch to enable inspector tests on luciddream.
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0da3c76a9836
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8668479 [details] [diff] [review] various inspector tests tweaks - v1 Patrick, Here is various tweaks for inspector tests, necessary for running on luciddream. See comment 2 for more info about these tweaks. Feel free to redirect the r? to whoever makes sense!
Attachment #8668479 -
Flags: review?(pbrosset)
Comment 6•9 years ago
|
||
Comment on attachment 8668479 [details] [diff] [review] various inspector tests tweaks - v1 Review of attachment 8668479 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/inspector/test/browser_inspector_breadcrumbs_highlight_hover.js @@ +7,5 @@ > // Test that hovering over nodes on the breadcrumb buttons in the inspector shows the highlighter over > // those nodes > add_task(function*() { > info("Loading the test document and opening the inspector"); > + let {toolbox, inspector, testActor} = yield openInspectorForURL("data:text/html;charset=utf-8,<h1>foo1</h1><span>bar</span>"); nit: if the document content needs to be unique because this helps when tests fail, then maybe make the content something like: <h1>breadcrumbs hover test</h1><span>highlight nodes on hover</span> The benefit I see to this is that now, when people copy/paste this test to create a new one, they will see this and probably change it to match whatever their new test does.
Attachment #8668479 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #6) > The benefit I see to this is that now, when people copy/paste this test to > create a new one, they will see this and probably change it to match > whatever their new test does. Good point!
Attachment #8668479 -
Attachment is obsolete: true
Assignee | ||
Comment 8•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4927e85be885
Assignee | ||
Comment 9•9 years ago
|
||
With yet another batch of inspector tests fixes, let's see how it runs on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=be674b3adb7b Looks mostly good locally.
Assignee | ||
Comment 10•9 years ago
|
||
Waiting for try results before proceeding to review. I'm going to merge this patch with the previous one before landing, but keep it seperate for now to ease review.
Assignee | ||
Comment 11•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=24bdffd3ad2e
Comment 12•8 years ago
|
||
Triaged as P3 for now, but since lucid dream isn't a priority anymore, we might want to close this.
Priority: -- → P3
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•