1199559 - produce generated AudioBuffer contents in a format suitable for direct use

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Karl Tomlinson (:karlt)]

We can avoid copies of buffers with content generated by decodeAudioData OfflineAudioContext and ScriptProcessorNode.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199559 permit writing to ThreadSharedFloatArrayBufferList when not shared r?padenot

bug 1199559 permit writing to ThreadSharedFloatArrayBufferList when not shared r?padenot

Being able to write to the channel data in the buffer list saves the creator
from needing to manage its own pointers to the channel data.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199559 add a helper to fallibly allocate ThreadSharedFloatArrayBufferList with buffers r?padenot

bug 1199559 add a helper to fallibly allocate ThreadSharedFloatArrayBufferList with buffers r?padenot

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199559 add a factory method to accept generated buffer contents in a format suitable for direct use r?padenot

bug 1199559 add a factory method to accept generated buffer contents in a format suitable for direct use r?padenot

This API lets AudioBuffer generators avoid a copy.

Future modifications to AudioBuffer will remove the unnecessary initial
allocation and zeroing.

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199559 write offline buffer in a format suitable for direct use by AudioBuffer r?padenot

bug 1199559 write offline buffer in a format suitable for direct use by AudioBuffer r?padenot

saving a copy.

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199559 write decodeAudioData buffer in a format suitable for direct use by AudioBuffer r?padenot

bug 1199559 write decodeAudioData buffer in a format suitable for direct use by AudioBuffer r?padenot

saving a copy.

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199559 write audioprocess input buffer in a format suitable for direct use by AudioBuffer r?padenot

bug 1199559 write audioprocess input buffer in a format suitable for direct use by AudioBuffer r?padenot

saving copying.

This also avoids graph thread allocations when input is null.

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199559 remove now unused SetRawChannelContents r?padenot

bug 1199559 remove now unused SetRawChannelContents r?padenot

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199560 finish offline audio context processing even when allocation fails r?padenot

bug 1199560 finish offline audio context processing even when allocation fails r?padenot

ProcessBlock() needs to return aFinished = true at some point.

Comment 9

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1199561 delay offline buffer allocation until non-null input is received r?padenot

bug 1199561 delay offline buffer allocation until non-null input is received r?padenot

The avoids the allocation and copying altogether when the output buffer
is silent.

Comment 10

[Karl Tomlinson (:karlt)]

I see bug 1135941 is already filed.
I'll leave the review requests for other bugs in this set in case it is easier to diff between the base and end of the set.

Comment 11

[Paul Adenot (:padenot)]

Comment on attachment 8653913 [details]
MozReview Request: bug 1199561 delay offline buffer allocation until non-null input is received r?padenot

https://reviewboard.mozilla.org/r/17569/#review15673

Comment 12

[Paul Adenot (:padenot)]

Comment on attachment 8653905 [details]
MozReview Request: bug 1199559 permit writing to ThreadSharedFloatArrayBufferList when not shared r?padenot

https://reviewboard.mozilla.org/r/17553/#review15675

Comment 13

[Paul Adenot (:padenot)]

Comment on attachment 8653906 [details]
MozReview Request: bug 1199559 add a helper to fallibly allocate ThreadSharedFloatArrayBufferList with buffers r?padenot

https://reviewboard.mozilla.org/r/17555/#review15677

Comment 14

[Paul Adenot (:padenot)]

Comment on attachment 8653907 [details]
MozReview Request: bug 1199559 add a factory method to accept generated buffer contents in a format suitable for direct use r?padenot

https://reviewboard.mozilla.org/r/17557/#review15679

Comment 15

[Paul Adenot (:padenot)]

Comment on attachment 8653909 [details]
MozReview Request: bug 1199559 write decodeAudioData buffer in a format suitable for direct use by AudioBuffer r?padenot

https://reviewboard.mozilla.org/r/17561/#review15683

Comment 16

[Paul Adenot (:padenot)]

Comment on attachment 8653910 [details]
MozReview Request: bug 1199559 write audioprocess input buffer in a format suitable for direct use by AudioBuffer r?padenot

https://reviewboard.mozilla.org/r/17563/#review15685

Comment 17

[Paul Adenot (:padenot)]

Comment on attachment 8653911 [details]
MozReview Request: bug 1199559 remove now unused SetRawChannelContents r?padenot

https://reviewboard.mozilla.org/r/17565/#review15687

Comment 18

[Paul Adenot (:padenot)]

Comment on attachment 8653912 [details]
MozReview Request: bug 1199560 finish offline audio context processing even when allocation fails r?padenot

https://reviewboard.mozilla.org/r/17567/#review15689

Comment 19

[Paul Adenot (:padenot)]

Comment on attachment 8653908 [details]
MozReview Request: bug 1199559 write offline buffer in a format suitable for direct use by AudioBuffer r?padenot

https://reviewboard.mozilla.org/r/17559/#review15681

Comment 20

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11cd78f326d9
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c981e0cb0fa
https://hg.mozilla.org/integration/mozilla-inbound/rev/255b7fc96151
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d78bbe7d5dc
https://hg.mozilla.org/integration/mozilla-inbound/rev/e934843c48cf
https://hg.mozilla.org/integration/mozilla-inbound/rev/c143ace1a0c7
https://hg.mozilla.org/integration/mozilla-inbound/rev/c08ff3257488

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11cd78f326d9
https://hg.mozilla.org/mozilla-central/rev/4c981e0cb0fa
https://hg.mozilla.org/mozilla-central/rev/255b7fc96151
https://hg.mozilla.org/mozilla-central/rev/5d78bbe7d5dc
https://hg.mozilla.org/mozilla-central/rev/e934843c48cf
https://hg.mozilla.org/mozilla-central/rev/c143ace1a0c7
https://hg.mozilla.org/mozilla-central/rev/c08ff3257488