1199605 - The music play icon does not disappear after we kill a playing music app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

Description

[Evan Tseng [:evanxd]]

STR.
1. Play music from music app
2. Long press home button
3. Swipe off the music app (Turn off)

Expected.
4. No playing icon & the volume control type should be "notification"

Actual.
4. Have playing icon & the volume control type is "media"

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] evanxd:bug-1199605 > mozilla-b2g:master

Comment 2

[Evan Tseng [:evanxd]]

The attachment in Comment 1 is the WIP patch.

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8655344 [details] [review]
[gaia] evanxd:bug-1199605 > mozilla-b2g:master

Hi John,

Could you review the patch?

Thanks.

Comment 5

[Evan Tseng [:evanxd]]

Updated patch for John's comments.

Comment 6

[Evan Tseng [:evanxd]]

https://github.com/evanxd/gaia/commit/a937d1a18b3e81b1506f72bb3a1ad21ee9ef305e

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8655344 [details] [review]
[gaia] evanxd:bug-1199605 > mozilla-b2g:master

Thanks. This version looks good to me. But please add at lease one integration test case for this case before merging.

According to our offline discussion, we should file a bug for creating more complex integration test cases for the change of audio channel policy. Please also do that before merging.

Comment 8

[Evan Tseng [:evanxd]]

Thanks for the review, John.

I'll add tests.

The updated patch: https://github.com/evanxd/gaia/commit/accec9b6dc2c0ee6ee100762330e99c9c5d57fc1

Comment 9

[Evan Tseng [:evanxd]]

We will write the full UI tests in Bug 1201379.

Comment 10

[Evan Tseng [:evanxd]]

Add tests[1]. If treeherder[2] is good, let's land the code.

[1]: https://github.com/evanxd/gaia/commit/16fcd45d8e69a851545adf294e36400f8ca9dadf
[2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=16fcd45d8e69a851545adf294e36400f8ca9dadf

Comment 11

[Evan Tseng [:evanxd]]

Comment on attachment 8655344 [details] [review]
[gaia] evanxd:bug-1199605 > mozilla-b2g:master

Hi Jim,

Could you review the marionette test part[1] of patch?
I added a test in Music app.

Thanks.

[1]: https://github.com/mozilla-b2g/gaia/pull/31633/files#diff-c6184496bf60ffae2f21ac71bd7a648aR143

Comment 12

[Hubert Figuiere [:hub]]

(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #11)
> Could you review the marionette test part[1] of patch?
> I added a test in Music app.


Maybe you should also do the same test in dev_app/music-nga ?

Test are roughly identical and music-nga aim to be the replacemeny Music app for 2.5

Thanks.

Comment 13

[Jim Porter (:squib)]

Comment on attachment 8655344 [details] [review]
[gaia] evanxd:bug-1199605 > mozilla-b2g:master

You'll want to update this to include tests in the NGA Music app too (dev_apps/music-nga), since we'll be making that the standard music app very soon. Once you've done that, ask :hub for review, since he knows the most about these tests.

Comment 14

[Evan Tseng [:evanxd]]

Comment on attachment 8655344 [details] [review]
[gaia] evanxd:bug-1199605 > mozilla-b2g:master

Hi Hubert,

Could you review the patch?

And looks like we change `dev_apps/music-nga` to `dev_apps/music-oga`.

Thanks.

Comment 15

[Hubert Figuiere [:hub]]

(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #14)
> And looks like we change `dev_apps/music-nga` to `dev_apps/music-oga`.

No we did apps/music -> dev_apps/music-oga and dev_apps/music-nga -> apps/music. No exactly the same. But git should have dealt with the properly.

Comment 16

[Hubert Figuiere [:hub]]

Comment on attachment 8655344 [details] [review]
[gaia] evanxd:bug-1199605 > mozilla-b2g:master

tests looks good.

Comment 17

[Evan Tseng [:evanxd]]

Hubert, thanks for the review.

Comment 18

[Evan Tseng [:evanxd]]

The treeherder is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=93f10ff6e54636b3b27e509463d735ccbc5d8e21

Comment 19

[Evan Tseng [:evanxd]]

If treeherder[1] is good, let's land the code.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=face47c7cccb3ca632f7ecb98b288e719cdd8aae

Comment 21

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/ed7a955a844a7162ce83812471d47e2994818012

Comment 22

[Lance（leave from Mozilla）]

Attachment: FlameKK_v2.5.3gp

This bug has been verified as "pass" on NGA & OGA music app of FlameKK v2.5 latest build by STR in comment 0.
Actually result: No playing icon & the volume control type should be "notification"
Reproduce rate: 0/5
See attachment: FlameKK_v2.5.3gp

Device: Flame KK v2.5(Pass)
Build ID               20151007150205
Gaia Revision          b99837aa2294348317bcae68acabe71d9a83d774
Gaia Date              2015-10-07 13:04:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e1fa696e2b626ead6817b7c5bd871fec5d5ab5a
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151007.183338
Firmware Date          Wed Oct  7 18:33:51 EDT 2015
Bootloader             L1TC000118D0